New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specifiers for virtual packages to the project toml file. #32
Comments
Im having a hard disscussion with myself on how we shoudl specify the virtual packages. [dependencies]
pytorch = "1.0"
__glibc = "2.17"
__aarchspec = { version = "1", build_string = "arm64"} |
Hmm, well, the problem is that these virtual dependencies specify a lower boundary on the system. E.g. with For that reason I think they are different enough to have their own section. We could also call the section
etc. |
I like @wolfv s approach! |
I like it too! will continue with that! |
Although for the “selector” (e.g. linux) we need a seperate system still. Ill create an issue tomorrow so we can discuss. |
Right now virtual packages in the solve are specified like: pub virtual_packages: Vec<GenericVirtualPackage> This expects a version, not a match spec. Should that be changed? |
No that is correct. It describes the availabe virtual packages available on the system. So its an explicit version not a matchspec. You can see it as the “installed” virtual packages. When we specify this in our project file it describes the minimum available virtual packages that should be present on the system for the lock file to be valid. Packages (and thus also dependencies) can also specify dependencies on virtual packages. These should go in the normal dependencies section. (just like you mentioned earlier) However there they are no different from any other dependency and therefor dont need special treatment. |
[system_requirements]
windows = true
unix = true
cuda = "12.2"
macos = "10.15"
libc = { family = "glibc", version = "2.12" }
[target.osx-arm64.system_requirements]
cuda = "12.1"
[target.'not(osx-arm64)'.system_requirements]
cuda = "12.3" So depending on the key the value is specific.. |
Allow users to define virtual packages in the project configuration.
The text was updated successfully, but these errors were encountered: