fix: use project root directory instead of task.working_directory for base dir when hashing

[wolfv]

Should improve #1139

I still want to implement a warning when glob does not match anything at all.

[ruben-arts]

Thanks!

[wolfv]

There is one behavior that we might still want to discuss.

If a glob is just outputs = ["built.txt"] it matches on any built.txt that is found anywhere (e.g. also build/built.txt).

When using /built.txt that seems to be avoided. Using ./built.txt doesn't seem to work though.

I think, intuitively I would expect a simple built.txt to only match in the root of the project and not anywhere else.

What do you think @bollwyvl?

[ruben-arts]

Oh that sounds a little weird, why does it auto glob on the name? I would expect it to be a path or if you do */build.txt it would start searching.

[wolfv]

I would argue that that's something we can fix in a follow-up PR as well (this one already contains a few improvements). WDYT/

[bollwyvl]

Nice. I see this was already merged, but ...

I think, intuitively I would expect a simple built.txt to only match in the root of the project and not anywhere else.

agreed, unlike .gitignore, this is including things, and inputs=["build.txt"] should likely not be found in multiple places unless there's a * in there.