test: incremental lock file updates #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
requested changes
Jun 26, 2023
tests/install_tests.rs
Outdated
| pixi.init().await.unwrap(); | ||
|
|
||
| // Set the channel to something we created | ||
| pixi.set_channel(Url::from_directory_path(channel_dir.path()).unwrap()) |
There was a problem hiding this comment.
Shouldn't we also add this option to the command line interface? Maybe even something like an add channel option or as argument to init?
There was a problem hiding this comment.
Yeah ideally we'd add this to the init command IMHO. I wasn't sure whether to do this in this PR though.
There was a problem hiding this comment.
I added channels to the init command and modified PixiControl to allow you to use it.
tdejager
approved these changes
Jun 27, 2023
| } | ||
| } | ||
|
|
||
| impl IntoFuture for InitBuilder { |
There was a problem hiding this comment.
Maybe add some documentation why this is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to generate repodata on the fly.
Not entirely happy with it will refactor on Monday.Refactored this and now pretty happy with it. :)Fix #4