Set linguist attributes for pixi.lock
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies syntax highlighting in the GitHub web interface, and treats it as a generated file.
|
Hey @spenserblack ! Thanks for your contribution! I was wondering, would you also be able to contribute adding the .gitattributes file when running pixi init? Similar to how we generate a default gitignore. |
baszalmstra
approved these changes
Aug 18, 2023
|
I'll see what I can do 🙂 So you're good with both attributes? Note that GitHub excludes generated files from PR diffs. So, while it might be accurate to label |
|
Done. Let me know if you want any more changes 🙂 |
|
Ah that is a problem indeed, I wasn't aware of that detail. In that case, lets remove the generated part. I think it is very important people are aware a lock file changed in a PR. |
baszalmstra
approved these changes
Aug 18, 2023
|
Thanks! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled on this project and figured I'd add this small nice-to-have.
This applies syntax highlighting in the GitHub web interface, and treats it as a generated file.
In the future, you might want to contribute to github-linguist so that GitHub has proper support for this filename, but, for now, a quick search shows that this file probably won't meet the popularity requirement.