Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell (config, workflow) to catch typos + catch and fix some of those #329

Merged
merged 11 commits into from
Sep 12, 2023

Conversation

yarikoptic
Copy link
Contributor

note: some fixes seems to be touching code and could be "functional"

@wolfv
Copy link
Member

wolfv commented Sep 8, 2023

Wow, thanks! This has caught some pretty nasty typos! 🚀

@@ -905,7 +905,7 @@ mod tests {
let file_contents = [
r#"
[system-requirements]
libc = { verion = "2.12" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was done on purpose :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done -- ignored now

Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this looks great! Thanks @yarikoptic !

Would you be able to fix the remaining CI issues? The test is failing because we test that an explicit misspelling of version causes an error during parsing but your changes "fixed" the misspelling. :) I left a comment where this happens.

@yarikoptic
Copy link
Contributor Author

fixed up for that verion in the test, rebased, let's see how it goes ;-)

yarikoptic and others added 9 commits September 12, 2023 09:32
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@wolfv wolfv merged commit 740f4de into prefix-dev:main Sep 12, 2023
9 checks passed
@yarikoptic yarikoptic deleted the enh-codespell branch September 12, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants