feat: initial minimal virtual package support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruben-arts
commented
May 30, 2023
ruben-arts
commented
- Add a minimal version of the virtual packages (excluding the Cuda one)
- Add a check to find if the current platform is at least matching the minimal packages for the platform
baszalmstra
reviewed
May 30, 2023
| virtual_packages | ||
| } | ||
|
|
||
| pub fn verify_current_platform_has_minimal_virtual_package_requirements( |
There was a problem hiding this comment.
Function is named a bit weird. It implies it will check the current platform but you actually pass in the platform.
There was a problem hiding this comment.
Also its missings docs.
There was a problem hiding this comment.
It is now checking the current platform itself and added some docs
src/virtual_packages.rs
Outdated
Comment on lines
5
to
8
| /// Define a reasonable modern set of virtual packages that should be safe enough to assume. | ||
| /// On design this is in sync with the conda-lock set of default packages. | ||
| /// https://github.com/conda/conda-lock/blob/3d36688278ebf4f65281de0846701d61d6017ed2/conda_lock/virtual_package.py#L175 | ||
| pub fn get_minimal_virtual_packages(platform: Platform) -> Vec<VirtualPackage> { |
There was a problem hiding this comment.
Function comments should always be written in the imperative form. e.g. "Returns a reasonable modern set of ..." instead of "Return a reasonable set ..."
There was a problem hiding this comment.
I think it looks better now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.