Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/autocomplete run tasks #390

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Feat/autocomplete run tasks #390

merged 11 commits into from
Oct 19, 2023

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Oct 16, 2023 •
edited
Loading

Adds auto completion for pixi run <TAB TAB> in bash and zsh .

closes #383 but not yet #372 as it doesn't activate the environment.

baszalmstra
baszalmstra reviewed Oct 17, 2023
View reviewed changes
src/cli/completion.rs Outdated Show resolved Hide resolved
src/cli/completion.rs Outdated Show resolved Hide resolved
src/cli/task.rs Show resolved Hide resolved
@ruben-arts ruben-arts added the enhancement New feature or request label Oct 18, 2023
baszalmstra
baszalmstra reviewed Oct 18, 2023
View reviewed changes
src/cli/completion.rs Outdated Show resolved Hide resolved
src/cli/completion.rs Show resolved Hide resolved
baszalmstra
baszalmstra reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To further reduce code duplication maybe extract the code to generate the clap_complete completion script string into a function which takes the shell as an argument? Then reuse that in the tests as well.

@baszalmstra baszalmstra merged commit 9561398 into prefix-dev:main Oct 19, 2023
9 checks passed
@ruben-arts ruben-arts deleted the feat/autocomplete_run_tasks branch October 19, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pixi tab completion should include runnable tasks under pixi run <tab>
2 participants
@ruben-arts @baszalmstra