Make the install dir target dependent #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would be better to use the dirs crate to find the correct location? But I also dont think this location is wrong (in home folder). Rustup does the same, so does pipx. Maybe we should just add that folder to path? And/or install pixi there? |
|
Alsco, both paths are also added by the installer to the PATH right? |
|
Ah I understood that the appdata folder was a better location. This is the only folder added to the path by the install script. |
|
Mm yeah you might have a point. Im not really sure what a sane default is. |
|
Pipx actually used the user data folder: https://github.com/pypa/pipx/blob/ce27a75ce757e165bb76e3b71a8380f3b28375e9/src/pipx/constants.py#L10C21-L10C35 Anaconda and rustup do put it in the home folder. I'm kinda confused now. |
baszalmstra
pushed a commit
that referenced
this pull request
Nov 14, 2023
Smaller solution than #448 Decided to keep it simple to also make the documentation simpler. Now it is just the home folder for everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I installed pixi it put pixi in
$home/AppData/Local/pixi/pixi.exeand also added that folder to the path.This is correct but the global install code was putting it in a different dir.
$home/.pixi/binwhich is normal for unix.