feat: --pypi for add command #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Dec 4, 2023
src/cli/add.rs
Outdated
| let requirement = PyPiRequirement::from(req); | ||
| Ok((name, requirement)) | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Why not just add the question mark here? Instead of mapping the result? Then the code below no longer needs the map.
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
baszalmstra
reviewed
Dec 5, 2023
baszalmstra
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will let the user add pypi packages to the
pixi.tomlExamples:
pixi add --pypi pytest matplotlib==3.8.0pixi add --pypi --platform linux-64 pytest<7Some notable mentions:
pixi addspec type is not amatchspecanymore but a normal string to create two code paths.[target.platfrom.pypi-dependencies]to the manifestpixi rm --pypi xyetCloses #498 and closes #499