feat(install): Add PIXI_NO_PATH_UPDATE for PATH update suppression
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
baszalmstra
approved these changes
Jan 20, 2024
ruben-arts
approved these changes
Jan 20, 2024
| ) | ||
|
|
||
| Set-StrictMode -Version Latest | ||
|
|
||
| function Publish-Env { |
There was a problem hiding this comment.
Cool wasn't aware you could do this!
|
This PR breaks the installer for linux in some cases where it fails with |
Merged
wolfv
pushed a commit
that referenced
this pull request
Jan 30, 2024
The linux installer was broken by #692 and fails currently with `bash: line 83: PIXI_NO_PATH_UPDATE: unbound variable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #686
The PR mainly adds the option of using a
PIXI_NO_PATH_UPDATEenvironment variable to suppress PATH update, when installing pixi from install script.Besides the option added, since the PR is about environment variable, the way of updating PATH in the PowerShell install script has also been modified from using
[Environment]::SetEnvironmentVariableto set environment variable to get and update environment variable from Windows registry.This change doesn't affect pixi installation directly and is primarily to address a potential issue that
SetEnvironmentVariableexpands all environment variables and this behavior may not be welcomed in some cases.Related code are copied from ScoopInstaller/Install I'm maintaining.