-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Default to PIXI_ENVIRONMENT_NAME in pixi list #900
Conversation
This also affects #889, there is a discussion going there about whether or not adding the environment variable is a good idea. I'd like to wait until that is resolved. |
While testing this, I found the below issue ![]() EnvironmentName::Default != EnvironmentName::Named("default") when searching in IndexMap Any recommendation on tackling this? |
I think we should maybe just refactor struct EnvironmentName(String) if the name is |
Alternatively you could first parse the |
This was fixed in #1080 |
closes #893
I went ahead with @pavelzw suggestion, please let me know if this needs to thought through