Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove cache: true from setup-pixi #950

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Mar 11, 2024

This is the default now and doesn't need to be specified

Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing as always! 🥇

Thanks!

@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 11, 2024

I think it would also make sense to briefly mention the github action on pixi.sh. Any suggestions on which page to put it in?

@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 11, 2024

How about in Basic Usage?

@baszalmstra
Copy link
Contributor

Perhaps as an example? @ruben-arts WDYT?

@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 11, 2024

I'm also thinking of just mirroring the complete README.md from setup-pixi and adding a

- [ ] updated readme for pixi.sh

in the pull request template of setup-pixi.
This might make for a better docs experience overall...

@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 11, 2024

I think polarify has a nice GHA integration. I could also add it as an example and describe what's happening under the hood a bit more.

@ruben-arts
Copy link
Contributor

Yeah we would love the setup-pixi docs to be integrated in pixi.sh we also want to do this for pixi-docker.
Could have it's own page, and be added in the navigation. Then we can link to it from the basic usage.
Multiple examples would always help!

@ruben-arts ruben-arts merged commit ee6d636 into prefix-dev:main Mar 11, 2024
2 checks passed
@pavelzw pavelzw deleted the patch-2 branch March 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants