feat: mark version as non-draft after release CI completes #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
requested changes
Feb 14, 2024
.github/workflows/rust.yml
Outdated
| - name: Set as latest release | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| run: | | ||
| gh release edit "v${{ steps.metadata.outputs.project-version }}" --draft=false |
There was a problem hiding this comment.
Hmm, I think we could just as well use the tag from the github.ref, right? Instead of trying to get it from Cargo.toml
wolfv
approved these changes
Feb 14, 2024
|
let's try with the next release :) |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this might be a short term solution - not tested but I'm positive that it will work