Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not take python variant when noarch:python #723

Merged
merged 2 commits into from Mar 22, 2024

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Mar 22, 2024

When having noarch: python in recipe

requirements:
  host:

    - python
    - pip
    - setuptools
  run:
    - pip

and also variants.yaml

python:
  # part of a zip_keys: python, python_impl, numpy
  - 3.8.* *_cpython
  - 3.9.* *_cpython

python_impl:
  # part of a zip_keys: python, python_impl, numpy
  - cpython
  - cpython
numpy:
  # part of a zip_keys: python, python_impl, numpy
  - 1.22
  - 1.22

rattler-build should render only one recipe and don't take into account python variants ( like how conda render do )

@nichmor nichmor requested a review from wolfv March 22, 2024 10:54
@wolfv
Copy link
Member

wolfv commented Mar 22, 2024

Cool! Can you add a test of some sort? Even if it's just a snapshot test of the rendering or something like that.

I think the variant_config.rs file deserves to be refactored some day but I am OK with merging this for now :)

@nichmor
Copy link
Contributor Author

nichmor commented Mar 22, 2024

Cool! Can you add a test of some sort? Even if it's just a snapshot test of the rendering or something like that.

I think the variant_config.rs file deserves to be refactored some day but I am OK with merging this for now :)

sure - I've added the test for it

@wolfv wolfv merged commit 2d8bba6 into prefix-dev:main Mar 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants