Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec pandas[performance] produces several errors #25

Closed
notatallshaw opened this issue Sep 28, 2023 · 2 comments · Fixed by #29
Closed

Spec pandas[performance] produces several errors #25

notatallshaw opened this issue Sep 28, 2023 · 2 comments · Fixed by #29

Comments

@notatallshaw
Copy link

Since Pandas 2.0 it is reccomended to add the performance optional extra: https://pandas.pydata.org/docs/getting_started/install.html#performance-dependencies-recommended

But rip seems to take a long time to resolve and produces several errors when you do this:

$ cargo r -- pandas[performance]
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/rip 'pandas[performance]'`
2023-09-28T17:50:46.015212Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2023.3.post1': failed to parse version '2011k'
2023-09-28T17:50:46.015323Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2023.3': failed to parse version '2011k'
2023-09-28T17:50:46.015378Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2023.2': failed to parse version '2011k'
2023-09-28T17:50:46.015430Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.7.1': failed to parse version '2011k'
2023-09-28T17:50:46.015481Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.7': failed to parse version '2011k'
2023-09-28T17:50:46.015531Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.6': failed to parse version '2011k'
2023-09-28T17:50:46.015581Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.5': failed to parse version '2011k'
2023-09-28T17:50:46.015631Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.4': failed to parse version '2011k'
2023-09-28T17:50:46.015681Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.2.1': failed to parse version '2011k'
2023-09-28T17:50:46.015732Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.2': failed to parse version '2011k'
2023-09-28T17:50:46.015782Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2022.1': failed to parse version '2011k'
2023-09-28T17:50:46.015831Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2021.3': failed to parse version '2011k'
2023-09-28T17:50:46.015888Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2021.1': failed to parse version '2011k'
2023-09-28T17:50:46.015938Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2020.5': failed to parse version '2011k'
2023-09-28T17:50:46.015979Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2020.4': failed to parse version '2011k'
2023-09-28T17:50:46.016021Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2020.1': failed to parse version '2011k'
2023-09-28T17:50:46.016063Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2019.3': failed to parse version '2011k'
2023-09-28T17:50:46.016104Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2019.2': failed to parse version '2011k'
2023-09-28T17:50:46.016146Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2019.1': failed to parse version '2011k'
2023-09-28T17:50:46.016188Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.9': failed to parse version '2011k'
2023-09-28T17:50:46.016229Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.7': failed to parse version '2011k'
2023-09-28T17:50:46.016270Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.6': failed to parse version '2011k'
2023-09-28T17:50:46.016312Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.5': failed to parse version '2011k'
2023-09-28T17:50:46.016353Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.4': failed to parse version '2011k'
2023-09-28T17:50:46.016395Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2018.3': failed to parse version '2011k'
2023-09-28T17:50:46.016437Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2017.3': failed to parse version '2011k'
2023-09-28T17:50:46.016478Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2017.2': failed to parse version '2011k'
2023-09-28T17:50:46.016520Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.10': failed to parse version '2011k'
2023-09-28T17:50:46.016562Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.7': failed to parse version '2011k'
2023-09-28T17:50:46.016603Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.6.1': failed to parse version '2011k'
2023-09-28T17:50:46.016646Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.6': failed to parse version '2011k'
2023-09-28T17:50:46.016687Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.4': failed to parse version '2011k'
2023-09-28T17:50:46.016728Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.3': failed to parse version '2011k'
2023-09-28T17:50:46.016770Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.2': failed to parse version '2011k'
2023-09-28T17:50:46.016811Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2016.1': failed to parse version '2011k'
2023-09-28T17:50:46.016853Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2015.7': failed to parse version '2011k'
2023-09-28T17:50:46.016898Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2015.6': failed to parse version '2011k'
2023-09-28T17:50:46.016940Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2015.4': failed to parse version '2011k'
2023-09-28T17:50:46.016981Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2015.2': failed to parse version '2011k'
2023-09-28T17:50:46.017023Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2014.10': failed to parse version '2011k'
2023-09-28T17:50:46.017065Z ERROR rattler_installs_packages::resolve: failed to determine if '>= 2011k' contains '2014.9': failed to parse version '2011k'
Resolved environment:
- pandas[performance]

Name                 Version
bottleneck           1.3.7
llvmlite             0.41.0
numba                0.58.0
numexpr              2.8.7
numpy                1.25.2
pandas[performance]  2.1.1
python-dateutil      2.8.2
pytz                 2023.3.post1
six                  1.16.0
tzdata               2023.3
@baszalmstra
Copy link
Contributor

Thanks I will take a closer look. For some reason, with the extras a lot of panda wheels are downloaded.

@baszalmstra
Copy link
Contributor

#29 should fix the performance issues with this case. It ensures that extras are more tightly coupled to their base package which ensures faster resolving.

The errors are left in for now, it basically causes some candidates to not be considered which is not a direct issue atm. We will have to fix that in the version parsing crate that we use.

tdejager pushed a commit that referenced this issue Sep 29, 2023
This PR adds constrains requirements on extras from the base package to
ensure that they are properly linked together when one one of the
versions of the base or an extra is required.

This PR also cleans up the output a little bit to reduce the amount of
clutter when debugging.

Fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants