Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-airflow resolution #75

Closed
tdejager opened this issue Nov 14, 2023 · 10 comments · Fixed by mamba-org/resolvo#15
Closed

apache-airflow resolution #75

tdejager opened this issue Nov 14, 2023 · 10 comments · Fixed by mamba-org/resolvo#15
Assignees
Labels
bug Something isn't working

Comments

@tdejager
Copy link
Contributor

tdejager commented Nov 14, 2023

When running

cargo r apache-airflow

we get the following error message.

thread 'main' panicked at 'internal error: entered unreachable code: when we get here it means that all candidates have been assigned false. This should not be able to happen at this point because during propagation the solvable should have been assigned false as well.', /Users/tdejager/.cargo/registry/src/index.crates.io-6f17d22bba15001f/resolvo-0.2.0/src/solver/mod.rs:584:53
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Some impossible statement is being hit, is being hit inside of resolvo.

@tdejager tdejager added the bug Something isn't working label Nov 16, 2023
@tdejager
Copy link
Contributor Author

@baszalmstra can you update with any progress made in resolvo :)?

@baszalmstra
Copy link
Contributor

I spent half a day debugging the issue. It looks like at some point something is not properly propagated but I cant figure out what causes it. I'll have to get back to it later.

@wolfv
Copy link
Member

wolfv commented Dec 21, 2023

I think we should:

  • write something in resolvo so that we can store all the rules, and recreate the state
  • then debug this

I also looked into it and could not yet figure out the root cause.

@sumanth-manchala
Copy link

Not sure if this helps,

cargo run openmetadata-managed-apis

which has dependency of apache-airflow>=2.2 works and installs apache-airflow version 2.6.3 which is valid since all the newer versions need opentelemetry-api and opentelemetry-exporter-otlp which cannot be installed as one of their dependency (opentelemetry-semantic-conventions) has only pre-release versions available

image

From the logs on the cargo run apache-airflow, I see rip

  • Trying to install the latest 2.8.0 version of airflow
  • Couldn't because of opentelemetry-api and opentelemetry-exporter-otlp deps
  • Backtracks to prev version 2.7.3 which exhausts all the stable variants of both opentelemetry deps and thereby panicking.

This should ideally backtracks to next version of 2.7.2 and so on.

Wish I could dig more on this, still at early days of Rust and understanding SAT solvers.

@sumanth-manchala
Copy link

sumanth-manchala commented Dec 26, 2023

I added a minimal integration test on resolvo which replicates this,

https://github.com/sumanth-manchala/resolvo/blob/airflow-int-test/tests/solver.rs#L462

@baszalmstra

@wolfv
Copy link
Member

wolfv commented Jan 9, 2024

Hi @sumanth-manchala this is amazing. I also tried to make a reproducer the other day, but didn't manage so I am really happy to see that you managed to do it!

Did you – perhaps – also work on a fix? This issue is certainly one that we would like to fix sooner rather than later :)

@wolfv
Copy link
Member

wolfv commented Jan 9, 2024

PS: do you want to make a PR with your changes? We could mark it as "expected fail" for now, too. Would love to give you credit for the test!

@sumanth-manchala
Copy link

Thanks @wolfv. Have added the integration test to expect panic, will ping here if I could figure out the fix

@tdejager
Copy link
Contributor Author

Yeah that's absolutely great work, @sumanth-manchala :) Jumping head first into such a gnarly problem couldn't have been easy! Thanks a lot 😄

baszalmstra added a commit to mamba-org/resolvo that referenced this issue Jan 10, 2024
Relates to prefix-dev/rip#75

---------

Co-authored-by: Bas Zalmstra <bas@prefix.dev>
@aochagavia
Copy link
Contributor

Just in case anyone out there is trying to debug this further, I'm pretty sure I've found the root cause of the issue and hope to have a fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants