Xcode embed libraries #1619
Merged
Xcode embed libraries #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2021 07:51
When entries in links are specified with an extension we treat them like frameworks for the most part. They are placed into the Frameworks group and added to the Frameworks build phase. We do have separate logic for the file reference, only because we never want to resolve a .dylib link to the /System/Frameworks directory. Instead we assume a .dylib link that is just a file name, e.g. 'libA.dylib', is relative to the project the same way as if it were prefixed with './'.
ghost
mentioned this pull request
starkos
approved these changes
Apr 19, 2021
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1524. I apparently deleted my fork at some point so in order to address the PR feedback I had to re-fork and open a new PR. My apologies for making this harder to track as a result.
0e93130 and 4ed7424 are just taken directly from #1524. 626eedb is the API change requested by @starkos in #1524. The tests all passed for me locally and I was able to generate an Xcode project that did the right thing so the changes still appear to work for me.