Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for embed and embedAndSign Xcode options #1893

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

thomashope
Copy link
Contributor

What does this PR do?

  1. Fleshes out the docs a little for embed and embedAndSign options
  2. Adds a guide with some explanation of how to use embedAndSign in practice

How does this PR change Premake's behavior?

It doesn't, just documentation!

Anything else we should know?

Docs relate to changes in #1518 and #1619

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thanks for this!

@KyrietS this looks like it contains all the required modifications for the docs, are you able to confirm?

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this PR earlier but forgot to approve it 😅
All looks good. Thanks @thomashope! We really appreciate your help 🤗

@KyrietS KyrietS merged commit 9245472 into premake:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants