Compiler Version support for Visual Studion 2017+ #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclark2016
commented
Jun 23, 2021
modules/vstudio/vs2010_vcxproj.lua
Outdated
Comment on lines
1702
to
1709
| elseif cfg.compileas == "Module" then | ||
| elseif cfg.compileas == "Module" then | ||
| m.element("CompileAs", condition, "CompileAsCppModule") | ||
| elseif cfg.compileas == "ModulePartition" then | ||
| elseif cfg.compileas == "ModulePartition" then | ||
| m.element("CompileAs", condition, "CompileAsCppModuleInternalPartition") | ||
| elseif cfg.compileas == "HeaderUnit" then | ||
| elseif cfg.compileas == "HeaderUnit" then |
There was a problem hiding this comment.
Looks like this got caught in light ending fixes.
nickclark2016
commented
Jun 23, 2021
src/_premake_init.lua
Outdated
Comment on lines
188
to
190
| "Module", | ||
| "ModulePartition", | ||
| "HeaderUnit" | ||
| "Module", | ||
| "ModulePartition", | ||
| "HeaderUnit" |
There was a problem hiding this comment.
Same as above. This was caught in line ending fixes.
|
Hey @nickclark2016, you forgot to add Btw. the latest version of docusaurus introduced some kind of automation for sidebars. It's not perfect yet but I'll try this feature in time. |
|
@KyrietS Ahh crap, yup, I'll do that. |
|
@nickclark2016 *cough* *cough* 🙃 |
Oh crap, totally slipped my mind. Standby |
6 tasks
KyrietS
added a commit
that referenced
this pull request
Jul 26, 2021
Updated sidebar to include toolsversion link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds compiler version support for VS 2017 and newer
How does this PR change Premake's behavior?
No breaking changes, all new functionality.
Syntax
This will add the following to the globals group in VS 2017 and newer project files.
It is worth noting that this does no checks for legal tool versions. That is on the user. I believe it would be more hassle than it is worth to go check for all installed tool version, then validate user input against that.
Anything else we should know?
Closes #1612
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!