Use business timezone info when filling in SAFT info #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the timezone was already being used for getting the documents for the given time period, we were not using the timezone for filling in the date releated fields. This meant that the daylight savings problems we were trying to fix could still happen
Todiogo99
reviewed
Jun 12, 2023
| @@ -1160,7 +1166,8 @@ private List<PaymentMethod> getPaymentsList(PTGenericInvoiceEntity document) | |||
| this.MAX_LENGTH_2, true)); | |||
| payment.setPaymentAmount(this | |||
| .validateBigDecimal(((PTPayment) p).getPaymentAmount())); | |||
| payment.setPaymentDate(this.formatDate(p.getPaymentDate())); | |||
| payment.setPaymentDate(this.formatLocalDate(LocalDate | |||
| .ofInstant(document.getDate().toInstant(), document.getBusiness().getTimezone()))); | |||
There was a problem hiding this comment.
This is the document creation date =/= payment date
There was a problem hiding this comment.
Fixed alongside another similar error I found while reviewing all the other changes I did
Todiogo99
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the timezone was already being used for getting the documents for the given time period, we were not using the timezone for filling in the date releated fields. This meant that the daylight savings problems we were trying to fix could still happen