Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(docs): auth section of v3.0 docs still contains v2.0 code #676

Closed
Akash187 opened this issue Apr 11, 2019 · 5 comments
Closed

bug(docs): auth section of v3.0 docs still contains v2.0 code #676

Akash187 opened this issue Apr 11, 2019 · 5 comments
Labels
Projects
Milestone

Comments

@Akash187
Copy link

Akash187 commented Apr 11, 2019

I just went through the documentation of react-redux-firebase and found that code in auth section (Wait For Auth To Be Ready) of v3.0 is not up to date actually contain v2.0 code if you compare it with the migration guide for v2 to v3.

Please consider updating it.

@prescottprue
Copy link
Owner

@Akash187 I was not aware of this, it must have slipped through. Thanks for reporting!

@prescottprue prescottprue changed the title Documentation is not upto date bug(docs): auth section of v3.0 docs still contains v2.0 code Apr 18, 2019
@prescottprue prescottprue added this to the v3.0.* milestone Apr 18, 2019
@Akash187
Copy link
Author

@prescottprue Happy to Help. You may close this thread if bug is fixed.

@WhoIsDT
Copy link

WhoIsDT commented May 4, 2019

Can you please help to repair store.firebaseAuthIsReady in 3.0 version? My app using this method but after update everything broke:(

@prescottprue
Copy link
Owner

prescottprue commented May 4, 2019

@WhoIsDT there is a bunch of discussion about that in this issue. Would be interested to hear your use case about why it is folks find it necessary to have things on the store - the new context API changes how things are done, so there isn't the instance on the store anymore (though this may get added back). firebaseAuthIsReady was intended for SSR, and so that bootup time of your app isn't long, it is suggested that you connect to auth from state and wait for it to load

@prescottprue prescottprue mentioned this issue Jul 13, 2019
3 tasks
prescottprue added a commit that referenced this issue Jul 13, 2019
* feat(types): add types for hooks including `useFirestore`, `useFirebase`, `useFirestoreConnect`, `useFirebaseConnect` - #653
* fix(types): make scopes optional in `credentials` - #671
* fix(docs): remove v2 auth ready docs from v3 docs - #676
* fix(providers): prevent unwanted re-initialization when parent component updates - #725 - @illuminist
* fix(profile): pass `updateProfile` options to action - #701 - @cruzdanilo 
* fix(firebaseConnect): remove `dispatch` from reserved props list - #675, #700
* feat(types): improve types for `withFirestore` and `withFirebase`
* feat(types): added `ExtendedFirebaseInstance` and `ExtendedFirestoreInstance` types
* feat(examples): update typescript example to use hooks
* fix(firestoreConnect): add error for passing of reserved props `firebase` and `firestore` when using `firestoreConnect`
* feat(types): add typing for firebase queries used in `firebaseConnect` and `useFirebaseConnect`
* fix(types): fix spelling of initialize in types
* feat(docs): add api docs pages for context providers and new hooks api 
* feat(docs): automatically find files for doc generation instead of having a constant that needs updating
* feat(core): add uglify and lodash plugins to webpack build to shrink bundle build size
@prescottprue
Copy link
Owner

Fixed in v3.0.0-alpha.13 release. Thanks for reporting!

@prescottprue prescottprue added this to Done in v3.0.0 via automation Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v3.0.0
  
Done
Development

No branches or pull requests

3 participants