fix(providers): prevent unwanted re-initialization when parent component updates - @illuminist #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! 🎆 Haven't tested it myself, but I checked out the code. Really excited to see the hooks continuing to move forward |
prescottprue
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.0.0-alpha.13 #725 +/- ##
=================================================
- Coverage 83.07% 80.3% -2.77%
=================================================
Files 30 30
Lines 969 1102 +133
Branches 178 193 +15
=================================================
+ Hits 805 885 +80
- Misses 164 217 +53 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Jul 13, 2019
* feat(types): add types for hooks including `useFirestore`, `useFirebase`, `useFirestoreConnect`, `useFirebaseConnect` - #653 * fix(types): make scopes optional in `credentials` - #671 * fix(docs): remove v2 auth ready docs from v3 docs - #676 * fix(providers): prevent unwanted re-initialization when parent component updates - #725 - @illuminist * fix(profile): pass `updateProfile` options to action - #701 - @cruzdanilo * fix(firebaseConnect): remove `dispatch` from reserved props list - #675, #700 * feat(types): improve types for `withFirestore` and `withFirebase` * feat(types): added `ExtendedFirebaseInstance` and `ExtendedFirestoreInstance` types * feat(examples): update typescript example to use hooks * fix(firestoreConnect): add error for passing of reserved props `firebase` and `firestore` when using `firestoreConnect` * feat(types): add typing for firebase queries used in `firebaseConnect` and `useFirebaseConnect` * fix(types): fix spelling of initialize in types * feat(docs): add api docs pages for context providers and new hooks api * feat(docs): automatically find files for doc generation instead of having a constant that needs updating * feat(core): add uglify and lodash plugins to webpack build to shrink bundle build size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrapped an extended firebase instance inside react useMemo hook in order to prevent
extendedFirebaseInstance.initializeAuth()from being called for second time when parent component updated. And it should has improved performance since it wouldn't callcreateFirebaseInstanceagain to create a new and change firebase instance in theReactReduxFirebaseContextwhich would cause update in every component that depends on firebase instance from said context.Check List
If not relevant to pull request, check off as complete