fix(populate): dispatch for errors during profile population #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.0.0-beta.14 #312 +/- ##
================================================
Coverage ? 83.5%
================================================
Files ? 22
Lines ? 2104
Branches ? 324
================================================
Hits ? 1757
Misses ? 347
Partials ? 0 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Oct 29, 2017
### Description * fix(typings): Updated type definitions - #311 * fix(populate): dispatch for errors during profile population - #312 * feat(firebaseConnect): `store` is passed as second argument of `firebaseConnect` - #278 * feat(firestoreConnect): `store` is passed as second argument of `firestoreConnect` * fix(query): `dispatchRemoveAction` is now `false` by default - prevents multiple state updates when calling `remove` if listener associated is attached ### Potentially Breaking * `store` being passed as second argument of `firebaseConnect` (and `firestoreConnect`), which means any components using that second argument will break (most commonly used for getting `uid`). To access `uid` or other info from redux state, use `store.getState()` like so: ```js firebaseConnect( (props, store) => { const { firebase: { auth } } = store.getState() // be careful, listeners are not re-attached when auth state changes unless props change return [{ path: `todos/${auth.uid || ''}` }] } ) ``` More details are included in [the migration guide](http://docs.react-redux-firebase.com/history/v2.0.0/docs/v2-migration-guide.html).
prescottprue
added a commit
that referenced
this pull request
Oct 29, 2017
* fix(typings): Updated type definitions - #311 * fix(populate): dispatch for errors during profile population - #312 * feat(firebaseConnect): `store` is passed as second argument of `firebaseConnect` - #278 * feat(firestoreConnect): `store` is passed as second argument of `firestoreConnect` * fix(query): `dispatchRemoveAction` is now `false` by default - prevents multiple state updates when calling `remove` if listener associated is attached * `store` being passed as second argument of `firebaseConnect` (and `firestoreConnect`), which means any components using that second argument will break (most commonly used for getting `uid`). To access `uid` or other info from redux state, use `store.getState()` like so: ```js firebaseConnect( (props, store) => { const { firebase: { auth } } = store.getState() // be careful, listeners are not re-attached when auth state changes unless props change return [{ path: `todos/${auth.uid || ''}` }] } ) ``` More details are included in [the migration guide](http://docs.react-redux-firebase.com/history/v2.0.0/docs/v2-migration-guide.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic to catch errors during profile parameter population. If a the client does not have access to the data to populate, SET_PROFILE is dispatched with the unpopulated profile. Previously, an uncaught error prevented the profile from being updated.
Check List
If not relevant to pull request, check off as complete
Relevant Issues