Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upward Commenting #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upward Commenting #303

wants to merge 1 commit into from

Conversation

Skian12
Copy link

@Skian12 Skian12 commented Jun 6, 2017

When we use NERDCommenter, in basically [count] determines how many lines selected 'downward' from the cursor.

so, we have a question "Can we make [count] determine how many lines selected 'upward' from the cursor?"

and this pull request is realize the question.

If you want to use this feature, you just type one more <leader> key.

for example, if you want to use |NERDComComment| 'downward', then just type [count]<leader>cc. but if you want to use |NERDComComment| 'upward', then type [count]<leader><leader>cc.

@alerque
Copy link
Member

alerque commented Jul 2, 2018

I'm a little confused about whether this is a good idea. I'm trying to think of any precedent for plugins working this way — or any commands in vim for that matter. This would be easy to write a macro for or create your own bindings, but I'm not sure it belongs in the core. Can you point out any other plugins that work this way? It just seems counter intuitive and a bit unorthodox. I'm happy to be proven wrong, but before including this I'd like to be convinced it's something that other users would expect to find and use this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants