-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoclose_netrw
configuration option
#822
Conversation
Closes preservim#821 This will add the `autoclose_netrw` configuration option. If set to 1 this will close out of vim if tagbar and netrw (or nerdtree) are the only remaining windows. If set to 0, then this will leave the netrw (or nerdtree) window if that is the only remaining window once tagbar is closed.
@alerque I was wondering your opinion on a point in this PR. If I'm understanding this correctly, in the current code, the Now if they do have nerdtree installed, as nerdtree provides an override for the netrw window, then if they follow the procedure in the issue, then as @WeissZucker pointed out, then the nerdtree window closes. So onto this PR... one of the goals of this is to provide consistent behavior for both the netrw and nerdtree windows, but at the same time I don't want to disrupt the workflow of people that are used to the current behavior. With current behavior, they each behave differently. So now adding the configuration option does allow for customization, however I want to make sure we set the default value correctly. I'm making an assumption that most people that are using tagbar, probably are also using nerdtree, so I set the default for the |
Do you have any plans to merge this pull request? It solves a very serious bug I encountered, that is, when using bufexplorer, nerdtree, and tagbar at the same time, operations in bufexplorer (such as deleting a buffer) have unexpected errors. |
@alvan yes I can merge it in. I was waiting for feedback from the community or other moderators as to the default value, however I can merge it in as is and then we can swap the default later if the default becomes an issue. |
i wish this default value is to |
@raven42 |
@Shane-XB-Qian / @alvan, I've changed the default to 0 based on your feedback. It seems more people are in favor of having this disabled by default, so we'll go with that. Thanks for the feedback. |
Closes #821
This will add the
autoclose_netrw
configuration option. If set to 1this will close out of vim if tagbar and netrw (or nerdtree) are the
only remaining windows. If set to 0, then this will leave the netrw (or
nerdtree) window if that is the only remaining window once tagbar is
closed.