Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight headers #74

Closed
mcandre opened this issue Apr 7, 2014 · 7 comments
Closed

Highlight headers #74

mcandre opened this issue Apr 7, 2014 · 7 comments

Comments

@mcandre
Copy link

mcandre commented Apr 7, 2014

Would be nice if # ... headers in markdown files were syntax highlighted like function names in source code files.

@jrhorn424
Copy link

Could you show a screenshot of what you want, and what is currently shown? An fuller example would be good, too. Is this what you meant?

# Section Foo <!-- color me -->
Foo foo foo.

# Section Bar <!-- color me -->
Bar bar bar.

@mcandre
Copy link
Author

mcandre commented Apr 15, 2014

Yes, that's it.

I would like the entire header line, from the pound sign # to the end of the line, highlighted in the same color as function names are highlighted.

@cirosantilli
Copy link
Collaborator

Personally I like the current color vividchalk gives me: its very easy to spot: #71 (comment).

What theme are you using?

@mcandre
Copy link
Author

mcandre commented Apr 23, 2014

I enjoy Benokai https://github.com/benjaminwhite/Benokai, a port of
Monokai.

On Wed, Apr 23, 2014 at 8:01 AM, Ciro Santilli notifications@github.comwrote:

Personally I like the current color vividchalk gives me: its very easy to
spot: #71 (comment)#71 (comment)
.

What theme are you using?


Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-41152524
.

Cheers,

Andrew Pennebaker
www.yellosoft.us

@cirosantilli
Copy link
Collaborator

@mcandre please provide a screenshot for your headers. Why do you want to make functions and headers have the same color?

@mcandre
Copy link
Author

mcandre commented Apr 23, 2014

markdown-mode in Emacs colors Markdown headers this way, and as a result,
it's much easier to spot them in a long Markdown text.

On Wed, Apr 23, 2014 at 12:05 PM, Ciro Santilli notifications@github.comwrote:

@mcandre https://github.com/mcandre please provide a screenshot for
your headers. What is the advantage of making functions and headers have
the same color?


Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-41180098
.

Cheers,

Andrew Pennebaker
www.yellosoft.us

@cirosantilli
Copy link
Collaborator

Closing with the following rationale:

Currently # ... is highlighted like the innerHTML of <h1>Header</h1>: this plugin uses the region htmlH1 which is the same that the default /usr/share/vim/vim73/syntax/html.vim, which is very logical and should not be changed. This is also what the default markdown.vim does.

If # ... is not readable enough, then <h1>Header</h1> should not be visible enough either, so this is in fact a bug with your color theme, and not this plugin.

Consider opening an issue for your colortheme, and using a theme like vividchalk in the meantime, which as shown at #71 (comment) makes headers very visible bold pink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants