Build latest vim quickly from git mirror. #211
Conversation
| @@ -1,9 +1,22 @@ | |||
| language: vim | |||
| language: ruby | |||
There was a problem hiding this comment.
What is the advantage of using ruby here? To test vim Ruby bindings? But then I with we'd also test other bindings like Python, etc. I don't think it's necessary right now since we don't do anything that depends on them.
There was a problem hiding this comment.
@cirosantilli I could be mistaken, but I couldn't find any documentation on travis' site regarding language: vim. If there is documentation of vim as a travis language, can you point me to it? AFAIK that means that the current tests use their base ruby image.
For this PR it doesn't matter what language is at the top so long as I know what versions I can switch on to differentiate stock & latest build. In that respect, the RVM versions are simply well known. I could have just as arbitrarily used python versions. If there is a list of vim versions provided I'll use that.
Regarding bindings, not relevant to my decision process as you can see. If you ever needed specific version of python you can just easily use a python: 2.6 line in the yml.
There was a problem hiding this comment.
I think Ruby its the default for unknown languages: http://docs.travis-ci.com/user/getting-started/#Note
There was a problem hiding this comment.
@cirosantilli Right so it is as I imagined. I guess it is just cosmetics. I'll return it to vim if you like.
|
@cirosantilli I think that takes care of your notes. Happy vimming & thanks for plugin. |
| @@ -1,9 +1,23 @@ | |||
| language: vim | |||
| rvm: | |||
| - 1.8.7 # Use stock | |||
| - 1.9.2 # Build latest | |||
There was a problem hiding this comment.
Why do this? Wouldn't it be possible to install everything in one go, and then run two test commands separately?
There was a problem hiding this comment.
@cirosantilli Test execution isolation. If one version of vim fails (say 7.4.x cuz of new/changed behaviour) it shouldn't crash the stock test. If you ran them one after the other and 'anded' the result, then on any failure you'd have to check the log & see which of the two sets of vader tests failed. By separating, less investigating/thinking.
There was a problem hiding this comment.
Ahh, this is useful then. How about using multiple env instead? http://docs.travis-ci.com/user/build-configuration/#The-Build-Matrix A bit more elegant since we don't care about Ruby, and easier to retrieve in the if checks, and would self document since strings. E.g. TEST=latest and TEST=package
There was a problem hiding this comment.
@cirosantilli Interesting, hadn't read up on how extensively you can customize the build matrix, even exclusions! Neat.
|
Thanks! Please squash to one commit. Also, what does |
* Executes test against travis package vim & latest 7.4.x * Fixes preservim#201
|
@cirosantilli I guess in my mind I was using it as meaning "off the shelf" as in from the system's packages. I can see how that's a bit more open to interpretation than "package". Done. |
Build latest vim quickly from git mirror.
|
@starcraftman thanks for this PR and for patiently updating it! |
From the language I understood you still wanted to test against stock & also latest vim 7.4 line. So that's what this does. You can later add any other version/config of vim by simply using another RVM.