-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added contributing guidelines and started tests as required by them #60
Added contributing guidelines and started tests as required by them #60
Conversation
Please review this as contributing guidelines are very important for a project. If no one respondes, I will merge the PR in 14 days. We can change the guidelines at any point in the future. |
Excellent. I think this is a great start to a welcome addition. Assuming this ends up merged, it would seem beneficial to resolve any lingering issues with the original Markdown spec test document (you have denoted two I believe), and then move on to adding test documents for other flavors. 👍 |
Fixed the typos.
|
Well, we could also merge this particular change into a separate branch. That way, the outstanding issues could be addressed in separate pull requests against that branch before the contribution guidelines were formally introduced to the project. |
Should probably move forward with this now that it's been open a couple weeks... |
Do you mean we can merge as is? I have been trying to get some time to further improve this, but work has been crazy... |
Well, I think the actual content is reasonably spelled out. The only change I might suggest at this point might be to tighten up the formatting of the CONTRIBUTING.md file, and maybe expand the failed test example. I tweaked your file and posted it to this gist. The rules themselves can be tweaked over time as needed of course. I think it would be good to get something out there to start, though. |
@ilikepi On your Gist where you joined lines you left 2 spaces instead of 1. Was it intentional? It does not seem to have any effect on GFM, and as far as I know should not have any effect on standard markdown (except if followed by a newline). Otherwise it seems good to me. |
Oh, no, it's just an outdated habit I'm too stubborn to try to fix. I have updated the gist. |
Ok, I'm merging the new Gist version. |
Added contributing guidelines and started tests as required by them
No description provided.