Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [bot] Run grit migration: Apply a GritQL pattern #674

Closed
wants to merge 3 commits into from

Conversation

grit-app[bot]
Copy link

@grit-app grit-app bot commented Nov 16, 2023

⚠️ This migration is out of date with the main branch. Update with Grit ⚠️

⚠️ This pull request was auto-generated with Grit. ⚠️

This pull request was created with these settings:

  • Target branch: master
  • Source files: MapBox.jsx
  • Preset pattern: react_to_hooks – This pattern converts React class components to functional components, with hooks.
Pattern body
engine marzano(0.1)
language js

// Most of the logic for this pattern is in react_hooks.grit
// https://github.com/getgrit/js/blob/main/.grit/patterns/react_hooks.grit

pattern regular_first_step() {
  $use_ref_from = .,
  $handler_callback_suffix = "Handler",
  first_step($use_ref_from, $handler_callback_suffix)
}

sequential {
    file(body = program(statements = some bubble($program) regular_first_step())),
    // Run it 3 times to converge
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file($body) where {
      $body <: program($statements),
      $statements <: bubble($body, $program) and {
        maybe adjust_imports(),
        add_more_imports(),
      }
    }
}

Please feel free to provide feedback on this pull request. Any comments will be incorporated into future migrations.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@eschutho eschutho changed the title [bot] Run grit migration: Apply a GritQL pattern chore:[bot] Run grit migration: Apply a GritQL pattern Nov 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d20b60e) 69.04% compared to head (1b4fff0) 66.93%.
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   69.04%   66.93%   -2.11%     
==========================================
  Files        1938     1938              
  Lines       75852    75833      -19     
  Branches     8427     8425       -2     
==========================================
- Hits        52370    50759    -1611     
- Misses      21312    22904    +1592     
  Partials     2170     2170              
Flag Coverage Δ
hive ?
mysql 78.22% <ø> (?)
postgres 78.32% <ø> (ø)
presto ?
python 78.46% <ø> (-4.42%) ⬇️
sqlite 76.97% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschutho eschutho closed this Nov 16, 2023
@eschutho eschutho reopened this Nov 16, 2023
@eschutho eschutho changed the title chore:[bot] Run grit migration: Apply a GritQL pattern chore: [bot] Run grit migration: Apply a GritQL pattern Nov 22, 2023
height,
}).fitBounds(bounds);
const { latitude, longitude, zoom } = mercator;
const MapBox = (props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const MapBox = (props) => {
const MapBox = props => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants