-
Notifications
You must be signed in to change notification settings - Fork 726
/
report.rb
747 lines (627 loc) · 21.9 KB
/
report.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
require 'cgi'
require 'set'
require 'brakeman/processors/output_processor'
require 'brakeman/util'
require 'terminal-table'
require 'highline/system_extensions'
require "csv"
require 'brakeman/version'
if CSV.const_defined? :Reader
# Ruby 1.8 compatible
require 'fastercsv'
Object.send(:remove_const, :CSV)
CSV = FasterCSV
else
# CSV is now FasterCSV in ruby 1.9
end
#Generates a report based on the Tracker and the results of
#Tracker#run_checks. Be sure to +run_checks+ before generating
#a report.
class Brakeman::Report
include Brakeman::Util
attr_reader :tracker, :checks
TEXT_CONFIDENCE = [ "High", "Medium", "Weak" ]
HTML_CONFIDENCE = [ "<span class='high-confidence'>High</span>",
"<span class='med-confidence'>Medium</span>",
"<span class='weak-confidence'>Weak</span>" ]
def initialize tracker
@tracker = tracker
@checks = tracker.checks
@element_id = 0 #Used for HTML ids
@warnings_summary = nil
@highlight_user_input = tracker.options[:highlight_user_input]
@ignored_summary = nil
end
#Generate summary table of what was parsed
def generate_overview html = false
warnings = all_warnings.length
ignored_warnings = checks.ignored_warnings
if html
load_and_render_erb('overview', binding)
else
Terminal::Table.new(:headings => ['Scanned/Reported', 'Total']) do |t|
t.add_row ['Controllers', tracker.controllers.length]
t.add_row ['Models', tracker.models.length - 1]
t.add_row ['Templates', number_of_templates(@tracker)]
t.add_row ['Errors', tracker.errors.length]
t.add_row ['Security Warnings', "#{warnings} (#{warnings_summary[:high_confidence]})"]
t.add_row ['Ignored Warnings', ignored_warnings.length]
end
end
end
#Generate table of how many warnings of each warning type were reported
def generate_warning_overview html = false
types = warnings_summary.keys | ignored_summary.keys
types.delete :high_confidence
if html
load_and_render_erb('warning_overview', binding)
else
Terminal::Table.new(:headings => ['Warning Type', 'Total']) do |t|
types.sort.each do |warning_type|
t.add_row [warning_type, warnings_summary[warning_type]]
end
end
end
end
#Generate table of errors or return nil if no errors
def generate_errors html = false
if tracker.errors.any?
if html
load_and_render_erb('error_overview', binding)
else
Terminal::Table.new(:headings => ['Error', 'Location']) do |t|
tracker.errors.each do |error|
t.add_row [error[:error], error[:backtrace][0]]
end
end
end
else
nil
end
end
#Generate table of general security warnings
def generate_warnings html = false
warning_messages = []
checks.warnings.each do |warning|
w = warning.to_row
if html
w["Confidence"] = HTML_CONFIDENCE[w["Confidence"]]
w["Message"] = with_context warning, w["Message"]
else
w["Confidence"] = TEXT_CONFIDENCE[w["Confidence"]]
w["Message"] = text_message warning, w["Message"]
end
warning_messages << w
end
stabilizer = 0
warning_messages = warning_messages.sort_by{|row| stabilizer += 1; [row['Confidence'], row['Warning Type'], row['Class'], stabilizer]}
if html
load_and_render_erb('security_warnings', binding)
else
if warning_messages.empty?
Terminal::Table.new(:headings => ['General Warnings']) do |t|
t.add_row ['[NONE]']
end
else
Terminal::Table.new(:headings => ["Confidence", "Class", "Method", "Warning Type", "Message"]) do |t|
warning_messages.each do |row|
t.add_row [row["Confidence"], row["Class"], row["Method"], row["Warning Type"], row["Message"]]
end
end
end
end
end
#Generate table of template warnings or return nil if no warnings
def generate_template_warnings html = false
if checks.template_warnings.any?
warnings = []
checks.template_warnings.each do |warning|
w = warning.to_row :template
if html
w["Confidence"] = HTML_CONFIDENCE[w["Confidence"]]
w["Message"] = with_context warning, w["Message"]
else
w["Confidence"] = TEXT_CONFIDENCE[w["Confidence"]]
w["Message"] = text_message warning, w["Message"]
end
warnings << w
end
return nil if warnings.empty?
stabilizer = 0
warnings = warnings.sort_by{|row| stabilizer += 1; [row["Confidence"], row["Warning Type"], row["Template"], stabilizer]}
if html
load_and_render_erb('view_warnings', binding)
else
Terminal::Table.new(:headings => ["Confidence", "Template", "Warning Type", "Message"]) do |t|
warnings.each do |warning|
t.add_row [warning["Confidence"], warning["Template"], warning["Warning Type"], warning["Message"]]
end
end
end
else
nil
end
end
#Generate table of model warnings or return nil if no warnings
def generate_model_warnings html = false
if checks.model_warnings.any?
warnings = []
checks.model_warnings.each do |warning|
w = warning.to_row :model
if html
w["Confidence"] = HTML_CONFIDENCE[w["Confidence"]]
w["Message"] = with_context warning, w["Message"]
else
w["Confidence"] = TEXT_CONFIDENCE[w["Confidence"]]
w["Message"] = text_message warning, w["Message"]
end
warnings << w
end
return nil if warnings.empty?
stabilizer = 0
warnings = warnings.sort_by{|row| stabilizer +=1; [row["Confidence"],row["Warning Type"], row["Model"], stabilizer]}
if html
load_and_render_erb('model_warnings', binding)
else
Terminal::Table.new(:headings => ["Confidence", "Model", "Warning Type", "Message"]) do |t|
warnings.each do |warning|
t.add_row [warning["Confidence"], warning["Model"], warning["Warning Type"], warning["Message"]]
end
end
end
else
nil
end
end
#Generate table of controller warnings or nil if no warnings
def generate_controller_warnings html = false
unless checks.controller_warnings.empty?
warnings = []
checks.controller_warnings.each do |warning|
w = warning.to_row :controller
if html
w["Confidence"] = HTML_CONFIDENCE[w["Confidence"]]
w["Message"] = with_context warning, w["Message"]
else
w["Confidence"] = TEXT_CONFIDENCE[w["Confidence"]]
w["Message"] = text_message warning, w["Message"]
end
warnings << w
end
return nil if warnings.empty?
stabilizer = 0
warnings = warnings.sort_by{|row| stabilizer +=1; [row["Confidence"], row["Warning Type"], row["Controller"], stabilizer]}
if html
load_and_render_erb('controller_warnings', binding)
else
Terminal::Table.new(:headings => ["Confidence", "Controller", "Warning Type", "Message"]) do |t|
warnings.each do |warning|
t.add_row [warning["Confidence"], warning["Controller"], warning["Warning Type"], warning["Message"]]
end
end
end
else
nil
end
end
#Generate table of controllers and routes found for those controllers
def generate_controllers html=false
controller_rows = []
tracker.controllers.keys.map{|k| k.to_s}.sort.each do |name|
name = name.to_sym
c = tracker.controllers[name]
if tracker.routes[:allow_all_actions] or tracker.routes[name] == :allow_all_actions
routes = c[:public].keys.map{|e| e.to_s}.sort.join(", ")
elsif tracker.routes[name].nil?
#No routes defined for this controller.
#This can happen when it is only a parent class
#for other controllers, for example.
routes = "[None]"
else
routes = (Set.new(c[:public].keys) & tracker.routes[name.to_sym]).
to_a.
map {|e| e.to_s}.
sort.
join(", ")
end
if routes == ""
routes = "[None]"
end
controller_rows << { "Name" => name.to_s,
"Parent" => c[:parent].to_s,
"Includes" => c[:includes].join(", "),
"Routes" => routes
}
end
controller_rows = controller_rows.sort_by{|row| row['Name']}
if html
load_and_render_erb('controller_overview', binding)
else
Terminal::Table.new(:headings => ['Name', 'Parent', 'Includes', 'Routes']) do |t|
controller_rows.each do |row|
t.add_row [row['Name'], row['Parent'], row['Includes'], row['Routes']]
end
end
end
end
#Generate listings of templates and their output
def generate_templates html = false
out_processor = Brakeman::OutputProcessor.new
template_rows = {}
tracker.templates.each do |name, template|
unless template[:outputs].empty?
template[:outputs].each do |out|
out = out_processor.format out
out = CGI.escapeHTML(out) if html
template_rows[name] ||= []
template_rows[name] << out.gsub("\n", ";").gsub(/\s+/, " ")
end
end
end
template_rows = template_rows.sort_by{|name, value| name.to_s}
if html
load_and_render_erb('template_overview', binding)
else
output = ''
template_rows.each do |template|
output << template.first.to_s << "\n\n"
table = Terminal::Table.new(:headings => ['Output']) do |t|
# template[1] is an array of calls
template[1].each do |v|
t.add_row [v]
end
end
output << table.to_s << "\n\n"
end
output
end
end
def generate_ignored_notes html = false
if checks.ignored_warnings
warnings = []
checks.ignored_warnings.each do |warning|
annotation = @annotations.find{|a| a[:digest] == warning.annotation_digest}
if annotation[:note] && annotation[:note].length > 0
warnings << {"Warning" => "#{warning.warning_type} (#{File.basename(warning.file)}:#{warning.line})",
"Note" => annotation[:note] }
end
end
if warnings.length > 0
if html
load_and_render_erb("ignored_notes", binding)
else
Terminal::Table.new(:headings => ['Warning', 'Note']) do |t|
warnings.each do |warning|
t.add_row [warning["Warning"], warning["Note"]]
end
end
end
end
end
end
#Generate HTML output
def to_html
out = html_header <<
generate_overview(true) <<
generate_warning_overview(true)
# Return early if only summarizing
if tracker.options[:summary_only]
return out
end
if tracker.options[:report_routes] or tracker.options[:debug]
out << generate_controllers(true).to_s
end
if tracker.options[:debug]
out << generate_templates(true).to_s
end
out << generate_errors(true).to_s
out << generate_warnings(true).to_s
out << generate_controller_warnings(true).to_s
out << generate_model_warnings(true).to_s
out << generate_template_warnings(true).to_s
out << generate_ignored_notes(true).to_s
out << "</body></html>"
end
#Output text version of the report
def to_s
out = text_header <<
"\n\n+SUMMARY+\n\n" <<
truncate_table(generate_overview.to_s) << "\n\n" <<
truncate_table(generate_warning_overview.to_s) << "\n"
#Return output early if only summarizing
if tracker.options[:summary_only]
return out
end
if tracker.options[:report_routes] or tracker.options[:debug]
out << "\n+CONTROLLERS+\n" <<
truncate_table(generate_controllers.to_s) << "\n"
end
if tracker.options[:debug]
out << "\n+TEMPLATES+\n\n" <<
truncate_table(generate_templates.to_s) << "\n"
end
res = generate_errors
out << "+Errors+\n" << truncate_table(res.to_s) if res
res = generate_warnings
out << "\n\n+SECURITY WARNINGS+\n\n" << truncate_table(res.to_s) if res
res = generate_controller_warnings
out << "\n\n\nController Warnings:\n\n" << truncate_table(res.to_s) if res
res = generate_model_warnings
out << "\n\n\nModel Warnings:\n\n" << truncate_table(res.to_s) if res
res = generate_template_warnings
out << "\n\nView Warnings:\n\n" << truncate_table(res.to_s) if res
res = generate_ignored_notes
out << "\n\nIgnored Warnings Notes:\n\n" << truncate_table(res.to_s) if res
out << "\n"
out
end
#Generate CSV output
def to_csv
output = csv_header
output << "\nSUMMARY\n"
output << table_to_csv(generate_overview) << "\n"
output << table_to_csv(generate_warning_overview) << "\n"
#Return output early if only summarizing
if tracker.options[:summary_only]
return output
end
if tracker.options[:report_routes] or tracker.options[:debug]
output << "CONTROLLERS\n"
output << table_to_csv(generate_controllers) << "\n"
end
if tracker.options[:debug]
output << "TEMPLATES\n\n"
output << table_to_csv(generate_templates) << "\n"
end
res = generate_errors
output << "ERRORS\n" << table_to_csv(res) << "\n" if res
res = generate_warnings
output << "SECURITY WARNINGS\n" << table_to_csv(res) << "\n" if res
output << "Controller Warnings\n"
res = generate_controller_warnings
output << table_to_csv(res) << "\n" if res
output << "Model Warnings\n"
res = generate_model_warnings
output << table_to_csv(res) << "\n" if res
res = generate_template_warnings
output << "Template Warnings\n"
output << table_to_csv(res) << "\n" if res
output
end
#Not yet implemented
def to_pdf
raise "PDF output is not yet supported."
end
def rails_version
if version = tracker.config[:rails_version]
return version
elsif tracker.options[:rails3]
return "3.x"
else
return "Unknown"
end
end
#Return header for HTML output. Uses CSS from tracker.options[:html_style]
def html_header
if File.exist? tracker.options[:html_style]
css = File.read tracker.options[:html_style]
else
raise "Cannot find CSS stylesheet for HTML: #{tracker.options[:html_style]}"
end
load_and_render_erb('header', binding)
end
#Generate header for text output
def text_header
"\n+BRAKEMAN REPORT+\n\nApplication path: #{File.expand_path tracker.options[:app_path]}\nRails version: #{rails_version}\nGenerated at #{Time.now}\nChecks run: #{checks.checks_run.sort.join(", ")}\n"
end
#Generate header for CSV output
def csv_header
header = CSV.generate_line(["Application Path", "Report Generation Time", "Checks Performed", "Rails Version"])
header << CSV.generate_line([File.expand_path(tracker.options[:app_path]), Time.now.to_s, checks.checks_run.sort.join(", "), rails_version])
"BRAKEMAN REPORT\n\n" + header
end
#Return summary of warnings in hash and store in @warnings_summary
def warnings_summary
return @warnings_summary if @warnings_summary
summary = Hash.new(0)
high_confidence_warnings = 0
[all_warnings].each do |warnings|
warnings.each do |warning|
summary[warning.warning_type.to_s] += 1
if warning.confidence == 0
high_confidence_warnings += 1
end
end
end
summary[:high_confidence] = high_confidence_warnings
@warnings_summary = summary
end
def ignored_summary
return @ignored_summary if @ignored_summary
summary = Hash.new(0)
checks.ignored_warnings.each do |warning|
summary[warning.warning_type.to_s] += 1
end
@ignored_summary = summary
end
#Escape warning message and highlight user input in text output
def text_message warning, message
if @highlight_user_input and warning.user_input
user_input = warning.format_user_input
message.gsub(user_input, "+#{user_input}+")
else
message
end
end
#Escape warning message and highlight user input in HTML output
def html_message warning, message
message = CGI.escapeHTML(message)
if @highlight_user_input and warning.user_input
user_input = CGI.escapeHTML(warning.format_user_input)
message.gsub!(user_input, "<span class=\"user_input\">#{user_input}</span>")
end
message
end
#Generate HTML for warnings, including context show/hidden via Javascript
def with_context warning, message
context = context_for warning
full_message = nil
if tracker.options[:message_limit] and
tracker.options[:message_limit] > 0 and
message.length > tracker.options[:message_limit]
full_message = html_message(warning, message)
message = message[0..tracker.options[:message_limit]] << "..."
end
message = html_message(warning, message)
if context.empty? and not full_message
return message
end
@element_id += 1
code_id = "context#@element_id"
message_id = "message#@element_id"
full_message_id = "full_message#@element_id"
alt = false
output = "<div class='warning_message' onClick=\"toggle('#{code_id}');toggle('#{message_id}');toggle('#{full_message_id}')\" >" <<
if full_message
"<span id='#{message_id}' style='display:block' >#{message}</span>" <<
"<span id='#{full_message_id}' style='display:none'>#{full_message}</span>"
else
message
end <<
"<table id='#{code_id}' class='context' style='display:none'>" <<
"<caption>#{warning_file_to_relative_path(warning.file)}</caption>"
unless context.empty?
if warning.line - 1 == 1 or warning.line + 1 == 1
error = " near_error"
elsif 1 == warning.line
error = " error"
else
error = ""
end
output << <<-HTML
<tr class='context first#{error}'>
<td class='context_line'>
<pre class='context'>#{context.first[0]}</pre>
</td>
<td class='context'>
<pre class='context'>#{CGI.escapeHTML context.first[1].chomp}</pre>
</td>
</tr>
HTML
if context.length > 1
output << context[1..-1].map do |code|
alt = !alt
if code[0] == warning.line - 1 or code[0] == warning.line + 1
error = " near_error"
elsif code[0] == warning.line
error = " error"
else
error = ""
end
<<-HTML
<tr class='context#{alt ? ' alt' : ''}#{error}'>
<td class='context_line'>
<pre class='context'>#{code[0]}</pre>
</td>
<td class='context'>
<pre class='context'>#{CGI.escapeHTML code[1].chomp}</pre>
</td>
</tr>
HTML
end.join
end
end
output << "</table></div>"
end
#Generated tab-separated output suitable for the Jenkins Brakeman Plugin:
#https://github.com/presidentbeef/brakeman-jenkins-plugin
def to_tabs
[[:warnings, "General"], [:controller_warnings, "Controller"],
[:model_warnings, "Model"], [:template_warnings, "Template"]].map do |meth, category|
checks.send(meth).map do |w|
line = w.line || 0
w.warning_type.gsub!(/[^\w\s]/, ' ')
"#{file_for w}\t#{line}\t#{w.warning_type}\t#{category}\t#{w.format_message}\t#{TEXT_CONFIDENCE[w.confidence]}"
end.join "\n"
end.join "\n"
end
def to_test
report = { :errors => tracker.errors,
:controllers => tracker.controllers,
:models => tracker.models,
:templates => tracker.templates
}
[:warnings, :controller_warnings, :model_warnings, :template_warnings].each do |meth|
report[meth] = @checks.send(meth)
report[meth].each do |w|
w.message = w.format_message
if w.code
w.code = w.format_code
else
w.code = ""
end
w.context = context_for(w).join("\n")
w.file = file_for w
end
end
report
end
def to_json
require 'json'
errors = tracker.errors.map{|e| { :error => e[:error], :location => e[:backtrace][0] }}
warnings = all_warnings.map { |w| w.to_hash }.sort_by{|w| w[:file]}
scan_info = {
:app_path => File.expand_path(tracker.options[:app_path]),
:rails_version => rails_version,
:security_warnings => all_warnings.length,
:timestamp => Time.now,
:checks_performed => checks.checks_run.sort,
:number_of_controllers =>tracker.controllers.length,
# ignore the "fake" model
:number_of_models => tracker.models.length - 1,
:number_of_templates => number_of_templates(@tracker),
:ruby_version => RUBY_VERSION,
:brakeman_version => Brakeman::Version
}
JSON.pretty_generate({
:scan_info => scan_info,
:warnings => warnings,
:errors => errors
})
end
def all_warnings
@all_warnings ||= @checks.all_warnings
end
def number_of_templates tracker
Set.new(tracker.templates.map {|k,v| v[:name].to_s[/[^.]+/]}).length
end
def filter_by_annotations annotations_file
load_annotations annotations_file
@checks.filter_by_annotations(@annotations)
end
private
def load_and_render_erb file, bind
content = File.read(File.expand_path("templates/#{file}.html.erb", File.dirname(__FILE__)))
template = ERB.new(content)
template.result(bind)
end
def to_annotation
warnings = @checks.all_warnings
warnings.map do |warning|
warning.file = warning_file_to_relative_path(warning.file)
warning.to_annotation
end.to_yaml
end
def load_annotations annotations_file
annotations_file ||= ""
[File.expand_path(annotations_file), File.expand_path("./.brakeman_annotations.yaml")].each do |f|
if File.exist? f and not File.directory? f
notify "[Notice] Using annotations in #{f}"
@annotations = YAML::load_file f
end
end
end
def warning_file_to_relative_path(warning_file)
(warning_file || '').gsub(tracker.options[:app_path], "").gsub(/^\//, '')
end
end