New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError - using Code Climate with upgrade to 4.3.0 #1210

Closed
efueger opened this Issue May 17, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@efueger

efueger commented May 17, 2018

Error

Code Climate user running into an error, starting May 15.

engine brakeman failed with status 1 and stderr 
/usr/src/app/lib/brakeman/processors/controller_alias_processor.rb:183:in `process_template': undefined method `+' for nil:NilClass (NoMethodError)
	from /usr/src/app/lib/brakeman/processors/controller_alias_processor.rb:173:in `process_default_render'
	from /usr/src/app/lib/brakeman/processors/controller_alias_processor.rb:100:in `block in process_defn'
	from /usr/src/app/lib/brakeman/processors/alias_processor.rb:432:in `block in meth_env'
	from /usr/local/bundle/gems/sexp_processor-4.11.0/lib/sexp_processor.rb:452:in `scope'...

Background

  • Code Climate upgraded the builder for Brakeman's new 4.3.0 version on May 15.
  • Repo was running Brakeman analysis before with no probs 👌
  • reach out to @efueger (Support at Code Climate) if you need more details from the logs!
@presidentbeef

This comment has been minimized.

Owner

presidentbeef commented May 17, 2018

Hi Emily,

Thank you for reporting this. I am a little mystified currently as to why the version change would have had any effect.

I will see if I can reproduce the issue.

presidentbeef added a commit that referenced this issue May 18, 2018

Fix guard for missing method source
when setting line for implicit renders.

Should fix #1210
@presidentbeef

This comment has been minimized.

Owner

presidentbeef commented May 18, 2018

@efueger can you please try 91591c6 and see if that resolves the issue?

@efueger

This comment has been minimized.

efueger commented May 18, 2018

Thanks @presidentbeef! I'll loop in my dev colleagues to try that out.

@pirvudoru

This comment has been minimized.

pirvudoru commented May 23, 2018

@efueger Did your colleagues have the chance to look over this patch ?

@larkinscott

This comment has been minimized.

larkinscott commented May 23, 2018

Hey @presidentbeef - thanks for the quick patch! This looks good to me.

Repository owner locked and limited conversation to collaborators Jul 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.