Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a check for tap #1507

Closed
gavingmiller opened this issue Aug 20, 2020 · 0 comments
Closed

Create a check for tap #1507

gavingmiller opened this issue Aug 20, 2020 · 0 comments
Labels
new check
Milestone
5.0

Comments

@gavingmiller
Copy link
Contributor

gavingmiller commented Aug 20, 2020 •
edited
Loading

There was a lovely blog post on the 12 ways to call a method in Ruby. And it turns out some of these do not get caught by the brakeman scanner and could be abused.

The first example that I found was tap (way # 8 in the reference post):

Kernel.tap(&params[:method].to_sym)

The above when called with method=gets will DOS the application and does not currently get caught by brakeman.

Related issue: #1508
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
new check
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@presidentbeef @gavingmiller