Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking a method as "safe" doesn't work in this case #52

Closed
oreoshake opened this issue Mar 6, 2012 · 1 comment
Closed

Marking a method as "safe" doesn't work in this case #52

oreoshake opened this issue Mar 6, 2012 · 1 comment

Comments

@oreoshake
Copy link
Contributor

Without rails_xss on a Rails 2.x project, marking a method as safe doesn't seem to work if the method call is in a block

brakeman . -s made_up

link_to 'http://brakemanscanner.org' do
   made_up
end

Triggers a warning but

link_to made_up, 'http://brakemanscanner.org' 

does not.

@presidentbeef
Copy link
Owner

Hmmm...I can't repro this.

I used this in a view:

<%= link_to 'http://brakemanscanner.org' do
  made_up params[:x]
end %>

Which raised a warning. Then ran with -s made_up and it didn't raise a warning.

Repository owner locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants