We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brakeman/lib/brakeman/checks/check_render.rb
Line 72 in 2bd52a0
I am getting a warning High error warning on this line in my code:
render params[:action], status: status
I think that this is safe, because rails overrides 'action' parameters with the controller's action method.
see this line:
https://github.com/rails/rails/blob/0450642c27af3af35b449208b21695fd55c30f90/actionpack/lib/action_dispatch/http/parameters.rb#L30
I think that params[:action] and params[:controller] should not trigger a warning.
The text was updated successfully, but these errors were encountered:
Hi Kevin,
I think you are right. It's no problem to exclude those two keys.
Sorry, something went wrong.
Avoid render warning on :action/:controller params
59110a7
fixes #812
Successfully merging a pull request may close this issue.
brakeman/lib/brakeman/checks/check_render.rb
Line 72 in 2bd52a0
I am getting a warning High error warning on this line in my code:
I think that this is safe, because rails overrides 'action' parameters with the controller's action method.
see this line:
https://github.com/rails/rails/blob/0450642c27af3af35b449208b21695fd55c30f90/actionpack/lib/action_dispatch/http/parameters.rb#L30
I think that params[:action] and params[:controller] should not trigger a warning.
The text was updated successfully, but these errors were encountered: