Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic render path error too aggressive #812

Closed
KevinColemanInc opened this issue Jan 29, 2016 · 1 comment · Fixed by #816
Closed

dynamic render path error too aggressive #812

KevinColemanInc opened this issue Jan 29, 2016 · 1 comment · Fixed by #816

Comments

@KevinColemanInc
Copy link

I am getting a warning High error warning on this line in my code:

render params[:action], status: status

I think that this is safe, because rails overrides 'action' parameters with the controller's action method.

see this line:

https://github.com/rails/rails/blob/0450642c27af3af35b449208b21695fd55c30f90/actionpack/lib/action_dispatch/http/parameters.rb#L30

I think that params[:action] and params[:controller] should not trigger a warning.

@presidentbeef
Copy link
Owner

Hi Kevin,

I think you are right. It's no problem to exclude those two keys.

Repository owner locked and limited conversation to collaborators May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants