Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: "Render path contains parameter value" for "render @clients" #959

Open
mltsy opened this issue Nov 9, 2016 · 1 comment

Comments

@mltsy
Copy link

mltsy commented Nov 9, 2016

I have a view that uses render @clients to render a collection of clients as a partial.

The controller code that sets the @clients collection involves values from the params hash, as is fairly common:

@clients = Client.includes(:domain).where("clients.name LIKE ? OR domains.name LIKE ?",
  "%#{params[:search]}%", "%#{params[:search]}%").[...]

I don't know if that's why, but for some reason brakeman is reporting:

Render path contains parameter value

@presidentbeef
Copy link
Owner

Hi Joe,

Yes, seems that's why. I think this is similar to #529 which I should come back around to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants