fix: avoid detecting 'ViewComponentContrib::Base' as dynamic render paths #1821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds support for view_component-contrib gem.
view_component-contrib
is a support library for ViewComponent, which defines ViewComponent using theclass SomeComponent < ViewComponentContrib::Base
instead ofclass SomeComponent < ViewComponent::Base
.(
ViewComponentContrib::Base
is a class that extendsViewComponent::Base
(see: https://github.com/palkan/view_component-contrib/blob/master/lib/ view_component_contrib/base.rb))This PR prevents brakeman from detecting a Component using ViewCompontontrib as an occurrence of Dynamic Render Paths.
Background 📜
This problem is similar to what used to happen in the past for view_components:
#1529
#1578
#1805