-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configurable engines path #857
Conversation
This commit adds an `engines_path` option to brakeman to allow users to add engines that the application uses. The path to the engines can either be absolute or relative to the project root.
Needs to be added as an actual commandline option :) in https://github.com/presidentbeef/brakeman/blob/master/lib/brakeman/options.rb |
@presidentbeef added. :) |
Hi Jason, sorry for the delay on this. Committing to reviewing your pull requests tomorrow (Friday). |
Thanks! No worries. 😉 |
The Additionally, the option should be able to specify the top of the directory (e.g. |
Merging with #948 |
This PR is to add support for scanning engines that are not on the
engines/
path.This is the first step needed to fix #664. See #664 (comment).
This PR adds an
engines_path
option to brakeman to allow users to add engines that the application uses. The path to the engines can either be absolute or relative to the project root. For example, if thebrakeman.yml
config file contains this:Brakeman will scan the
engines/user_removal
directory relative to the project root. If the path starts with a forward slash, we assume that the path is relative. Like so: