Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isolate fieldset styles to legacy catalog (resolves #368) #370

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

greatislander
Copy link
Contributor

Resolves #368.

  • Functional
  • Attractive

@codecov-commenter
Copy link

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (e804c10) compared to base (bf6ac8c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #370   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        595     595           
=====================================
  Misses       595     595           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more functional. We'll likely want to make some aesthetic improvements before next release, but this is great start. We'll take it from here -- thank you Ned!

@SteelWagstaff SteelWagstaff merged commit 0f93a69 into pressbooks:dev Nov 4, 2022
@greatislander greatislander deleted the fix/wp-6.1-compat branch November 4, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix styles on signup page
3 participants