New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize TOC and chapter numbering in webbook #151
Comments
dac514
added a commit
that referenced
this issue
Mar 23, 2018
… use $post_id Depends on pressbooks/pressbooks#1165 Related to #151
greatislander
pushed a commit
that referenced
this issue
Mar 23, 2018
dac514
added a commit
that referenced
this issue
Mar 26, 2018
greatislander
pushed a commit
that referenced
this issue
Nov 6, 2018
greatislander
pushed a commit
that referenced
this issue
Dec 14, 2018
…406) Bumps [pressbooks-build-tools](https://github.com/pressbooks/pressbooks-build-tools) from 0.13.0 to 1.0.0. <details> <summary>Release notes</summary> *Sourced from [pressbooks-build-tools's releases](https://github.com/pressbooks/pressbooks-build-tools/releases).* > ## Pressbooks Build Tools 1.0.0 > ### Major Changes > > - Bump babel-eslint from 8.2.6 to 9.0.0: [#166](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/166) > - Bump babel-eslint from 9.0.0 to 10.0.0: [#173](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/173) > - Bump eslint-config-react-app from 2.1.0 to 3.0.3: [#178](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/178) > - Add eslint-plugin-jquery: [#179](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/179) > - Bump eslint-plugin-flowtype from 2.50.3 to 3.0.0: [#183](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/183) > - Bump laravel-mix from 2.1.14 to 3.0.0: [#200](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/200) > - Bump laravel-mix from 3.0.0 to 4.0.4: [#204](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/204) > > ### Minor Changes > > - Bump eslint-loader from 2.0.0 to 2.1.0: [#150](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/150) > - Bump eslint from 5.1.0 to 5.2.0: [#153](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/153) > - Bump stylelint-scss from 3.1.3 to 3.2.0: [#152](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/152) > - Bump prettier from 1.13.7 to 1.14.0: [#155](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/155) > - Bump eslint from 5.2.0 to 5.3.0: [#156](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/156) > - Bump eslint from 5.3.0 to 5.5.0: [#167](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/167) > - Bump eslint from 5.5.0 to 5.6.0: [#168](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/168) > - Bump stylelint-scss from 3.2.0 to 3.3.1: [#172](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/172) > - Bump stylelint from 9.3.0 to 9.6.0: [#174](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/174) > - Bump eslint-plugin-import from 2.13.0 to 2.14.0: [#159](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/159) > - Bump laravel-mix from 2.0.0 to 2.1.14: [#164](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/164) > - Bump eslint-plugin-react from 7.10.0 to 7.11.1: [#161](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/161) > - Bump browser-sync from 2.24.7 to 2.26.0: [#181](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/181) > - Bump eslint from 5.6.1 to 5.7.0: [#182](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/182) > - Bump stylelint from 9.6.0 to 9.7.0: [#187](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/187) > - Bump eslint from 5.7.0 to 5.8.0: [#188](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/188) > - Bump eslint-plugin-flowtype from 3.0.0 to 3.1.4: [#189](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/189) > - Bump eslint-plugin-flowtype from 3.1.4 to 3.2.0: [#192](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/192) > - Bump stylelint-scss from 3.3.2 to 3.4.0: [#193](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/193) > - Bump prettier from 1.14.3 to 1.15.1: [#194](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/194) > - Bump stylelint from 9.7.1 to 9.8.0: [#196](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/196) > - Bump eslint from 5.8.0 to 5.9.0: [#197](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/197) > - Update package-lock.json: e499a4657c75537a5cc61e0a6b23dc0f15a504ba > - Bump stylelint from 9.8.0 to 9.9.0: [#199](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/199) > - Bump eslint from 5.9.0 to 5.10.0: [#203](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/203) > > ### Patches > > - Bump browser-sync from 2.24.5 to 2.24.6: [#151](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/151) > - Bump prettier from 1.14.0 to 1.14.2: [#157](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/157) > - Bump browser-sync from 2.24.6 to 2.24.7: [#165](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/165) > - Bump eslint-plugin-flowtype from 2.50.0 to 2.50.1: [#169](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/169) > - Bump eslint-loader from 2.1.0 to 2.1.1: [#170](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/170) > - Bump prettier from 1.14.2 to 1.14.3: [#171](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/171) > - Bump babel-eslint from 10.0.0 to 10.0.1: [#176](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/176) > - Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3: [#175](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/175) > - Bump eslint from 5.6.0 to 5.6.1: [#177](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/177) ></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`6489283`](pressbooks/pressbooks-build-tools@6489283) Bump laravel-mix from 4.0.6 to 4.0.7 ([#206](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/206)) - [`4f44cca`](pressbooks/pressbooks-build-tools@4f44cca) 1.0.0 - [`d1ccbd9`](pressbooks/pressbooks-build-tools@d1ccbd9) Update package-lock.json - [`f404146`](pressbooks/pressbooks-build-tools@f404146) Bump laravel-mix from 4.0.4 to 4.0.6 ([#205](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/205)) - [`d848fd8`](pressbooks/pressbooks-build-tools@d848fd8) Audit fix - [`351ea4d`](pressbooks/pressbooks-build-tools@351ea4d) Bump laravel-mix from 3.0.0 to 4.0.4 ([#204](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/204)) - [`ba3a6c2`](pressbooks/pressbooks-build-tools@ba3a6c2) Bump eslint from 5.9.0 to 5.10.0 ([#203](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/203)) - [`28e526b`](pressbooks/pressbooks-build-tools@28e526b) Bump stylelint-scss from 3.4.0 to 3.4.1 ([#202](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/202)) - [`d8cd447`](pressbooks/pressbooks-build-tools@d8cd447) Bump laravel-mix from 2.1.14 to 3.0.0 ([#200](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/200)) - [`1acc6cc`](pressbooks/pressbooks-build-tools@1acc6cc) Bump prettier from 1.15.2 to 1.15.3 ([#201](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/201)) - Additional commits viewable in [compare view](pressbooks/pressbooks-build-tools@0.13.0...1.0.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=pressbooks-build-tools&package-manager=npm_and_yarn&previous-version=0.13.0&new-version=1.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=pressbooks-build-tools&package-manager=npm_and_yarn&previous-version=0.13.0&new-version=1.0.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
greatislander
pushed a commit
that referenced
this issue
Dec 14, 2018
…#407) Bumps [pressbooks-build-tools](https://github.com/pressbooks/pressbooks-build-tools) from 0.13.0 to 1.0.0. <details> <summary>Release notes</summary> *Sourced from [pressbooks-build-tools's releases](https://github.com/pressbooks/pressbooks-build-tools/releases).* > ## Pressbooks Build Tools 1.0.0 > ### Major Changes > > - Bump babel-eslint from 8.2.6 to 9.0.0: [#166](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/166) > - Bump babel-eslint from 9.0.0 to 10.0.0: [#173](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/173) > - Bump eslint-config-react-app from 2.1.0 to 3.0.3: [#178](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/178) > - Add eslint-plugin-jquery: [#179](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/179) > - Bump eslint-plugin-flowtype from 2.50.3 to 3.0.0: [#183](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/183) > - Bump laravel-mix from 2.1.14 to 3.0.0: [#200](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/200) > - Bump laravel-mix from 3.0.0 to 4.0.4: [#204](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/204) > > ### Minor Changes > > - Bump eslint-loader from 2.0.0 to 2.1.0: [#150](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/150) > - Bump eslint from 5.1.0 to 5.2.0: [#153](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/153) > - Bump stylelint-scss from 3.1.3 to 3.2.0: [#152](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/152) > - Bump prettier from 1.13.7 to 1.14.0: [#155](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/155) > - Bump eslint from 5.2.0 to 5.3.0: [#156](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/156) > - Bump eslint from 5.3.0 to 5.5.0: [#167](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/167) > - Bump eslint from 5.5.0 to 5.6.0: [#168](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/168) > - Bump stylelint-scss from 3.2.0 to 3.3.1: [#172](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/172) > - Bump stylelint from 9.3.0 to 9.6.0: [#174](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/174) > - Bump eslint-plugin-import from 2.13.0 to 2.14.0: [#159](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/159) > - Bump laravel-mix from 2.0.0 to 2.1.14: [#164](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/164) > - Bump eslint-plugin-react from 7.10.0 to 7.11.1: [#161](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/161) > - Bump browser-sync from 2.24.7 to 2.26.0: [#181](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/181) > - Bump eslint from 5.6.1 to 5.7.0: [#182](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/182) > - Bump stylelint from 9.6.0 to 9.7.0: [#187](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/187) > - Bump eslint from 5.7.0 to 5.8.0: [#188](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/188) > - Bump eslint-plugin-flowtype from 3.0.0 to 3.1.4: [#189](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/189) > - Bump eslint-plugin-flowtype from 3.1.4 to 3.2.0: [#192](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/192) > - Bump stylelint-scss from 3.3.2 to 3.4.0: [#193](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/193) > - Bump prettier from 1.14.3 to 1.15.1: [#194](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/194) > - Bump stylelint from 9.7.1 to 9.8.0: [#196](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/196) > - Bump eslint from 5.8.0 to 5.9.0: [#197](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/197) > - Update package-lock.json: e499a4657c75537a5cc61e0a6b23dc0f15a504ba > - Bump stylelint from 9.8.0 to 9.9.0: [#199](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/199) > - Bump eslint from 5.9.0 to 5.10.0: [#203](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/203) > > ### Patches > > - Bump browser-sync from 2.24.5 to 2.24.6: [#151](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/151) > - Bump prettier from 1.14.0 to 1.14.2: [#157](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/157) > - Bump browser-sync from 2.24.6 to 2.24.7: [#165](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/165) > - Bump eslint-plugin-flowtype from 2.50.0 to 2.50.1: [#169](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/169) > - Bump eslint-loader from 2.1.0 to 2.1.1: [#170](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/170) > - Bump prettier from 1.14.2 to 1.14.3: [#171](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/171) > - Bump babel-eslint from 10.0.0 to 10.0.1: [#176](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/176) > - Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3: [#175](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/175) > - Bump eslint from 5.6.0 to 5.6.1: [#177](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/177) ></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`6489283`](pressbooks/pressbooks-build-tools@6489283) Bump laravel-mix from 4.0.6 to 4.0.7 ([#206](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/206)) - [`4f44cca`](pressbooks/pressbooks-build-tools@4f44cca) 1.0.0 - [`d1ccbd9`](pressbooks/pressbooks-build-tools@d1ccbd9) Update package-lock.json - [`f404146`](pressbooks/pressbooks-build-tools@f404146) Bump laravel-mix from 4.0.4 to 4.0.6 ([#205](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/205)) - [`d848fd8`](pressbooks/pressbooks-build-tools@d848fd8) Audit fix - [`351ea4d`](pressbooks/pressbooks-build-tools@351ea4d) Bump laravel-mix from 3.0.0 to 4.0.4 ([#204](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/204)) - [`ba3a6c2`](pressbooks/pressbooks-build-tools@ba3a6c2) Bump eslint from 5.9.0 to 5.10.0 ([#203](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/203)) - [`28e526b`](pressbooks/pressbooks-build-tools@28e526b) Bump stylelint-scss from 3.4.0 to 3.4.1 ([#202](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/202)) - [`d8cd447`](pressbooks/pressbooks-build-tools@d8cd447) Bump laravel-mix from 2.1.14 to 3.0.0 ([#200](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/200)) - [`1acc6cc`](pressbooks/pressbooks-build-tools@1acc6cc) Bump prettier from 1.15.2 to 1.15.3 ([#201](https://github-redirect.dependabot.com/pressbooks/pressbooks-build-tools/issues/201)) - Additional commits viewable in [compare view](pressbooks/pressbooks-build-tools@0.13.0...1.0.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=pressbooks-build-tools&package-manager=npm_and_yarn&previous-version=0.13.0&new-version=1.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=pressbooks-build-tools&package-manager=npm_and_yarn&previous-version=0.13.0&new-version=1.0.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Description
We're still having some consistency/performance issues with part and chapter output in the webbook TOC. To address:
pb_get_chapter_number()
function should be removed wherever possible. One caveat here is that although the book structure array contains all chapters which need to be counted, some of them may benumberless
which means they need to be skipped in the numbering routine.pb_get_chapter_number()
function, when used on single chapter views, should be updated to better handle duplicate slugs/avoid collisions, etc.chapter-17
so that we can target it with CSS and indicate that it is the current chapter.Steps to Reproduce
Not applicable.
System Information
McLuhan: 2.1.0
The text was updated successfully, but these errors were encountered: