Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter licenses fix #472

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Chapter licenses fix #472

merged 2 commits into from
Jan 22, 2019

Conversation

dac514
Copy link
Contributor

@dac514 dac514 commented Jan 21, 2019

Unless chapter is licensed differently, it should display the book license statement

Depends on pressbooks/pressbooks#1561

Unless chapter is licensed differently, it should display the book license statement

Depends on pressbooks/pressbooks#1561
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #472 into dev will increase coverage by 1.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #472      +/-   ##
==========================================
+ Coverage   31.41%   32.45%   +1.03%     
==========================================
  Files           4        4              
  Lines         417      416       -1     
==========================================
+ Hits          131      135       +4     
+ Misses        286      281       -5
Impacted Files Coverage Δ
inc/helpers/namespace.php 46.79% <100%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c875289...fcb215e. Read the comment docs.

@greatislander greatislander added this to the 2.8.0 milestone Jan 22, 2019
@greatislander greatislander added the enhancement New feature or request label Jan 22, 2019
@greatislander greatislander self-assigned this Jan 22, 2019
@greatislander greatislander merged commit 1969452 into dev Jan 22, 2019
@greatislander greatislander deleted the chapter-license-fix branch January 22, 2019 13:05
greatislander pushed a commit that referenced this pull request Jan 28, 2019
@greatislander greatislander restored the chapter-license-fix branch January 28, 2019 19:00
@greatislander greatislander deleted the chapter-license-fix branch January 28, 2019 19:00
@greatislander greatislander restored the chapter-license-fix branch January 28, 2019 19:01
greatislander pushed a commit that referenced this pull request Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants