Add global js a11y file, Add columnheader role to sortable table head…

…ers (fix #1636) (#1669)
pressbooks · Apr 17, 2019 · d17b6c4 · d17b6c4
1 parent 510f89b
commit d17b6c4
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/assets/dist/mix-manifest.json b/assets/dist/mix-manifest.json
@@ -1,4 +1,5 @@
 {
+    "/scripts/a11y.js": "/scripts/a11y.js?id=0beba81c49d2b08db734",
     "/scripts/anchor.js": "/scripts/anchor.js?id=aafffcd9fd35558755fa",
     "/styles/catalog.css": "/styles/catalog.css?id=5592c3bde401d0205d10",
     "/styles/colors-pb.css": "/styles/colors-pb.css?id=453776ab723bb7b7a9b8",

diff --git a/assets/dist/scripts/a11y.js b/assets/dist/scripts/a11y.js
diff --git a/assets/src/scripts/a11y.js b/assets/src/scripts/a11y.js
@@ -0,0 +1,5 @@
+jQuery( function ( $ ) {
+
+	// Add `role: columnheader` to Sortable Table headers
+	$( 'table.wp-list-table th' ).attr( 'role', 'columnheader' );
+} )
diff --git a/inc/admin/laf/namespace.php b/inc/admin/laf/namespace.php
@@ -1067,6 +1067,10 @@ function ( $path ) use ( $assets ) {
 	// Always enqueue jquery and jquery-ui-core because we use them all over the place
 	wp_enqueue_script( 'jquery' );
 	wp_enqueue_script( 'jquery-ui-core' );
+
+	// A11y
+	wp_register_script( 'pb-a11y', $assets->getPath( 'scripts/a11y.js' ), [ 'jquery' ] );
+	wp_enqueue_script( 'pb-a11y' );
 }
 
 /* ------------------------------------------------------------------------ *

diff --git a/webpack.mix.js b/webpack.mix.js
@@ -32,13 +32,13 @@ mix.browserSync( {
 } );
 
 // Normalize Newlines
-const normalizeNewlines = ( dir ) => {
-	fs.readdirSync( dir ).forEach( function( file ) {
+const normalizeNewlines = dir => {
+	fs.readdirSync( dir ).forEach( function ( file ) {
 		file = path.join( dir, file );
-		fs.readFile( file, 'utf8', function( err, buffer ) {
+		fs.readFile( file, 'utf8', function ( err, buffer ) {
 			if ( err ) return console.log( err );
 			buffer = normalizeNewline( buffer );
-			fs.writeFile( file, buffer, 'utf8', function( err ) {
+			fs.writeFile( file, buffer, 'utf8', function ( err ) {
 				if ( err ) return console.log( err );
 			} );
 		} );
@@ -75,6 +75,7 @@ mix
 	.js( 'assets/src/scripts/textboxes-legacy.js', 'assets/dist/scripts/' )
 	.js( 'assets/src/scripts/theme-lock.js', 'assets/dist/scripts/' )
 	.js( 'assets/src/scripts/theme-options.js', 'assets/dist/scripts/' )
+	.js( 'assets/src/scripts/a11y.js', 'assets/dist/scripts/' )
 	.scripts(
 		'node_modules/event-source-polyfill/src/eventsource.js',
 		'assets/dist/scripts/eventsource.polyfill.js'