Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix book component heading markup in XHTML/EPUB #1035

Closed
4 tasks done
greatislander opened this issue Jan 8, 2018 · 0 comments · Fixed by #1045
Closed
4 tasks done

Fix book component heading markup in XHTML/EPUB #1035

greatislander opened this issue Jan 8, 2018 · 0 comments · Fixed by #1045
Assignees
@greatislander
Labels
enhancement
Milestone
5.0

Comments

@greatislander
Copy link
Contributor

Prerequisites

Description

All heading elements for book components, (front matter, chapters, and back matter) should be wrapped in a container element so they can be styled properly — but only if their theme is based on Buckram, as legacy themes do not support this layout/method of styling.

Requires changes to:

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 5.0-dev
WordPress: 4.9.1
PHP: 7.1
@greatislander greatislander added this to the 5.0 milestone Jan 8, 2018
@greatislander greatislander self-assigned this Jan 8, 2018
@greatislander greatislander mentioned this issue Jan 8, 2018
Closed
@greatislander greatislander mentioned this issue Jan 15, 2018
Merged
greatislander pushed a commit that referenced this issue Jan 15, 2018
Wrap chapter, front & back matter heading elements in EPUB and XHTML (f…
b10cafe 
…ixes #1035) (#1045)

* Update XHTML output.
* Simplify XHTML output logic; add EPUB support.
* Use theme support, add tests.
* Add HTMLBook to latest files list, add more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement
Projects
None yet
Milestone
5.0
1 participant
@greatislander