Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to prettify HTML outputs #1036

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Add ability to prettify HTML outputs #1036

merged 2 commits into from
Jan 12, 2018

Conversation

dac514
Copy link
Contributor

@dac514 dac514 commented Jan 8, 2018

Debugging feature,

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #1036 into dev will decrease coverage by 0.06%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##               dev    #1036      +/-   ##
===========================================
- Coverage     49.8%   49.74%   -0.07%     
- Complexity    3395     3397       +2     
===========================================
  Files           87       87              
  Lines        14865    14874       +9     
===========================================
- Hits          7404     7399       -5     
- Misses        7461     7475      +14

@greatislander greatislander self-requested a review January 8, 2018 19:46
Copy link
Contributor

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connerbw I don't know if this is intentional but should we add the $tidy option to the HTMLBook beta as well?

@dac514
Copy link
Contributor Author

dac514 commented Jan 8, 2018

It's intentional. We can't tidy XTHML by default because we don't want to introduce bugs (what do formatting and extra spaces do to existing outputs? Probably nothing but we can't know for sure.). My hope HTMLBook/HTML5 should be tidy from the start.

@greatislander greatislander added this to the 5.0 milestone Jan 12, 2018
@greatislander greatislander merged commit 966847d into dev Jan 12, 2018
@greatislander greatislander deleted the pretty branch January 12, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants