Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in digital PDFs should be visually highlighted #1306

Closed
4 tasks done
greatislander opened this issue Aug 2, 2018 · 1 comment · Fixed by pressbooks/pressbooks-book#359
Closed
4 tasks done

Links in digital PDFs should be visually highlighted #1306

greatislander opened this issue Aug 2, 2018 · 1 comment · Fixed by pressbooks/pressbooks-book#359
Assignees
@greatislander
Labels
a11y bug
Milestone
5.6.0

Comments

@greatislander
Copy link
Contributor

Prerequisites

Description

In print PDF, links are removed. However in digital PDF, they are present but not distinguished from surrounding content.

Steps to Reproduce

  1. Add a link to the content of a chapter.
  2. Export to digital PDF.
  3. Find the link.

Expected behavior: It is underlined and (optionally) a different colour.

Actual behavior: It is identical to the surrounding content.

System Information

Pressbooks: 5.5.0-dev
McLuhan: 2.5.0-dev
@greatislander greatislander added this to the 5.5.0 milestone Aug 2, 2018
@greatislander greatislander self-assigned this Aug 2, 2018
@greatislander greatislander modified the milestones: 5.5.0, 5.6.0 Aug 29, 2018
@greatislander greatislander mentioned this issue Oct 31, 2018
Closed
@greatislander
Copy link
Contributor Author

Blocked by #1437.

@greatislander greatislander mentioned this issue Nov 7, 2018
Closed
greatislander pushed a commit to pressbooks/pressbooks-jacobs that referenced this issue Nov 7, 2018
Remove link colors
5308142 
(fix pressbooks/pressbooks#1306)
@greatislander greatislander reopened this Nov 7, 2018
greatislander pushed a commit to pressbooks/pressbooks-book that referenced this issue Nov 7, 2018
Add link differention for print/digital (fix #317 and pressbooks/pres…
f3b92fb 
…sbooks#1306)
@greatislander greatislander mentioned this issue Nov 7, 2018
Merged
greatislander pushed a commit to pressbooks/pressbooks-book that referenced this issue Nov 7, 2018
Add link differention for print/digital (fix #317) (#359)
c088a77 
Also fixes pressbooks/pressbooks#1306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
a11y bug
Projects
None yet
Milestone
5.6.0
Development

Successfully merging a pull request may close this issue.

Add link differention for print/digital (fix #317) pressbooks/pressbooks-book
1 participant
@greatislander