Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JavaScript adding 'main' to wp-signup page #2152

Closed
SteelWagstaff opened this issue May 5, 2021 · 1 comment · Fixed by #2216
Closed

Remove JavaScript adding 'main' to wp-signup page #2152

SteelWagstaff opened this issue May 5, 2021 · 1 comment · Fixed by #2216
Assignees
@arzola @SteelWagstaff

Comments

@SteelWagstaff
Copy link
Member

We can revert these changes: 426b73a, now that this issue has been fixed upstream in WordPress 5.4. See https://core.trac.wordpress.org/changeset/47075
@sentry-io
Copy link

sentry-io bot commented May 5, 2021

Sentry issue: PRESSBOOKS-85

@SteelWagstaff SteelWagstaff self-assigned this Jun 6, 2021
@SteelWagstaff SteelWagstaff added this to the 5.23.0 milestone Jun 10, 2021
@SteelWagstaff SteelWagstaff mentioned this issue Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arzola arzola

@SteelWagstaff SteelWagstaff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unneeded JavaScript & test pressbooks/pressbooks
2 participants
@arzola @SteelWagstaff