Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content licensing #805

Closed
greatislander opened this issue Jun 20, 2017 · 13 comments

Comments

@greatislander
Copy link
Collaborator

commented Jun 20, 2017

Prerequisites

Description

Licensing (Creative Commons flavours, public domain, etc.) should available for all content: books, parts/chapters/front matter/back matter, and media. See also: #108, #195, https://github.com/lumenlearning/candela-citation

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 4.0.0-dev
WordPress: 4.8.0
PHP: 7.1

@greatislander greatislander added this to the 4.0 milestone Jun 20, 2017

@greatislander greatislander self-assigned this Jun 20, 2017

greatislander added a commit that referenced this issue Jun 26, 2017
Add section metadata endpoint (fixes #806).
Add current license information to metadata endpoints (see #805).

@greatislander greatislander modified the milestones: 4.1, 4.0 Jun 26, 2017

greatislander added a commit that referenced this issue Jun 26, 2017
Add section metadata endpoint (fixes #806) (#815)
* Add section metadata endpoint (fixes #806).
* Add current license information to metadata endpoints (see #805).
* Make section metadata look more like revisions
* Change $request['id'] to $request['parent']
* Add missing PHPDoc.
* Add tests.

@greatislander greatislander modified the milestones: 4.1, 4.2 Jul 12, 2017

@hughmcguire

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

Hi Ned, here is a detailed spreadsheet (conceptual & then detailed) of how the licensing module in general should work:
https://docs.google.com/spreadsheets/d/1pMFuNUF9fRFBEN8VlfPasXFp2y6tvZyuTfEAa7T02eE/edit

@connerbw connerbw self-assigned this Jul 26, 2017

@zwhnz

This comment has been minimized.

Copy link

commented Jul 31, 2017

Testing Notes

All exports:

Custom/freeform notice should appear after the auto license on copyright page.

EPUB:

Section license does not display correctly at end of section & I have had two different results. With same license, on one chapter the image is missing but text is present, in other chapter image is missing and text cuts off at author.

Check an EPUB export here: https://testbook.textopress.com/wp-admin/

MOBI:

CC license image does not appear at end of section (copyright page ok).

PDF:

Section license appears correctly at end of section, but could benefit from some styling. Is this easy to do? I could write up a snippet.

Webbook:

Freeform/custom copyright notice does not appear in footer, just the auto license text.

@greatislander greatislander assigned connerbw and unassigned zwhnz and apurvaashok Jul 31, 2017

@greatislander greatislander reopened this Jul 31, 2017

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 31, 2017

@connerbw Can you fix as many of these issues as you can? I think the PDF styling will be the sticking point so you can leave that for me.

@connerbw

This comment has been minimized.

Copy link
Member

commented Aug 1, 2017

TODO: PDF: Section license appears correctly at end of section, but could benefit from some styling. Is this easy to do? I could write up a snippet.

@greatislander greatislander modified the milestones: 4.1, 4.2 Aug 1, 2017

@greatislander greatislander assigned zwhnz and unassigned greatislander Aug 2, 2017

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 2, 2017

@zwhpressbooks This should be all fixed except for the PDF styling which I'll check tomorrow.

@apurvaashok

This comment has been minimized.

Copy link

commented Aug 8, 2017

Testing Notes

All exports:

Custom/freeform notice appears after the auto license on copyright page.

EPUB:

Section license displays correctly at end of section.

MOBI:

CC license image appears at end of section. However, the author name is linked to the corresponding section on the Pressbooks webbook. Is this the desired behaviour?

Check an export here: https://apurvatestbook.textopress.com/wp-admin/

PDF:

Still waiting on styling.

Webbook:

Freeform/custom copyright notice appears in footer, below the chapter/book-level license.

@connerbw

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

After a week of hanging out at the cottage, then coming back to this issue, it feels rough around the edges.

TODO: PDF styling, can we improve Epub end of section with a line break or something, MOBI author name link.

Wait until @zwhpressbooks is back from vacation to discuss?

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2017

I've added default styles for PDF and EPUB:

text-align: center;
font-size: 0.8em;
font-style: italic;
margin-top: 2em;

Also removed the links to webbook in other formats.

@zwhnz

This comment has been minimized.

Copy link

commented Aug 16, 2017

Testing Notes

  • Author name still linked to webbook in both global and section licenses (PDF and ebook)
  • License image in MOBI is pretty small (don't know if we can do anything about that)
    Note: ignore the link in place of the author name, I had the field blank accidentally!

screen shot 2017-08-16 at 4 51 23 pm

  • Image and text are very close together in EPUB (again, don't know if we can do anything)

screen shot 2017-08-16 at 4 51 44 pm

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2017

  • The author name link should be there in the webbook, I think. At least until we have author profile pages. See: https://creativecommons.org/use-remix/get-permission/
  • I will add a bit more spacing to the image for EPUB and try to force it to be a specific size in MOBI
@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2017

Back to you!

@zwhnz

This comment has been minimized.

Copy link

commented Aug 17, 2017

EPUB spacing is much better, but image is still small in MOBI.

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2017

@zwhpressbooks I think MOBI image is fixed now, can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.