-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content licensing #805
Comments
Hi Ned, here is a detailed spreadsheet (conceptual & then detailed) of how the licensing module in general should work: |
Testing NotesAll exports:Custom/freeform notice should appear after the auto license on copyright page. EPUB:Section license does not display correctly at end of section & I have had two different results. With same license, on one chapter the image is missing but text is present, in other chapter image is missing and text cuts off at author. Check an EPUB export here: https://testbook.textopress.com/wp-admin/ MOBI:CC license image does not appear at end of section (copyright page ok). PDF:Section license appears correctly at end of section, but could benefit from some styling. Is this easy to do? I could write up a snippet. Webbook:Freeform/custom copyright notice does not appear in footer, just the auto license text. |
@connerbw Can you fix as many of these issues as you can? I think the PDF styling will be the sticking point so you can leave that for me. |
TODO: PDF: Section license appears correctly at end of section, but could benefit from some styling. Is this easy to do? I could write up a snippet. |
@zwhpressbooks This should be all fixed except for the PDF styling which I'll check tomorrow. |
Testing NotesAll exports:Custom/freeform notice appears after the auto license on copyright page. EPUB:Section license displays correctly at end of section. MOBI:CC license image appears at end of section. However, the author name is linked to the corresponding section on the Pressbooks webbook. Is this the desired behaviour? Check an export here: https://apurvatestbook.textopress.com/wp-admin/ PDF:Still waiting on styling. Webbook:Freeform/custom copyright notice appears in footer, below the chapter/book-level license. |
After a week of hanging out at the cottage, then coming back to this issue, it feels rough around the edges. TODO: PDF styling, can we improve Epub end of section with a line break or something, MOBI author name link. Wait until @zwhpressbooks is back from vacation to discuss? |
I've added default styles for PDF and EPUB:
Also removed the links to webbook in other formats. |
Testing Notes
|
|
Back to you! |
EPUB spacing is much better, but image is still small in MOBI. |
@zwhpressbooks I think MOBI image is fixed now, can you confirm? |
Prerequisites
Description
Licensing (Creative Commons flavours, public domain, etc.) should available for all content: books, parts/chapters/front matter/back matter, and media. See also: #108, #195, https://github.com/lumenlearning/candela-citation
Steps to Reproduce
Not applicable.
System Information
Pressbooks: 4.0.0-dev
WordPress: 4.8.0
PHP: 7.1
The text was updated successfully, but these errors were encountered: