Update globals path (fix pressbooks/pressbooks-book#307) #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1452 +/- ##
============================================
+ Coverage 62.48% 62.49% +<.01%
- Complexity 4332 4336 +4
============================================
Files 114 114
Lines 18915 18924 +9
============================================
+ Hits 11819 11826 +7
- Misses 7096 7098 +2 |
greatislander
force-pushed
the
globals-path
branch
from
ffe1213
to
cf1350a
Compare
added 7 commits
November 6, 2018 21:41
added 3 commits
November 6, 2018 22:15
dac514
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using Buckram in its new home at
/pressbooks-book/packages/buckram(see pressbooks/pressbooks-book#307), and updates related functions for normalizing CSS paths and loading Buckram image assets. In addition, since we don't use the EpubCheck apt package anywhere else (as it is a version that lacks the security update in 4.0.2), I switched to installing EpubCheck's latest jarfile. This also changes the default value of thePB_EPUBCHECK_COMMANDconstant to use the jarfile.