Fix bad config in sanitize_webbook_content #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac514
approved these changes
Nov 13, 2018
Codecov Report
@@ Coverage Diff @@
## dev #1462 +/- ##
=========================================
Coverage 62.74% 62.74%
Complexity 4350 4350
=========================================
Files 114 114
Lines 18957 18957
=========================================
Hits 11894 11894
Misses 7063 7063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1422 introduced a regression which applied (bad) HTMLawed defaults to webbook HTML by passing a
nullconfig. This passes an empty array config instead.