create new filter hook 'pb_cover_image' #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users who are not storing images locally on the server to hook in to the filter and use either the data in $cover variable or the data in $metadata['pb_cover_image'], in order to get cover images to display correctly.
ghost
mentioned this pull request
Current coverage is 12.44% (diff: 0.00%)@@ dev #540 diff @@
==========================================
Files 69 69
Lines 12140 12140
Methods 628 628
Messages 0 0
Branches 0 0
==========================================
Hits 1511 1511
Misses 10629 10629
Partials 0 0
|
|
Hi @monkecheese, this is a much preferable solution to me. Can I get you to document the hook in the line preceding its first use? I was doing some research into inline documentation and I am going to try to do this for all existing filter and action hooks. https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters |
|
sure thing, @greatislander! |
|
@greatislander, what version of pressbooks would this be rolled out in? (i need to put something for the "@SInCE" in the inline documentation) |
|
@monkecheese 3.9.5.1. Thanks! |
ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users who are not storing images locally on the
server to hook in to this filter and use either the data in the
$cover variable or the data in $metadata['pb_cover_image'], in
order to get cover images to display correctly depending on
their specific use case.