Migrate all #249
Closed
Migrate all #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Mar 29, 2021
| @@ -6,7 +6,7 @@ import ( | |||
| "log" | |||
| "os" | |||
|
|
|||
| "github.com/pressly/goose" | |||
| "github.com/quinnwinterfluid/goose" | |||
|
Hi! |
vitark
pushed a commit
to vitark/goose
that referenced
this pull request
Aug 26, 2021
|
I'd prefer not adding another function, and instead maintain the same behaviour but allow for an opt-in flag to apply all migrations. Maybe a quarter of existing issues are related to "apply all migrations, always" and this will be captured and fixed via #262 Closing this PR. There are some edge cases that need to be considered and I'd like to get this right to avoid messing with our internal processes while being able to offer this functionality to others using this package. Thanks for your patience. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New up-all command to offer a solution to the versioning issue.
up-allchecks all the migrations and applies any that have not been run yet.This helps to solve the versioning issue since with the current
upcommand if there is a more recent migration that has already been run, all pending migrations that were created before will stay in a pending state and not be run.